-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Use 'Omit' instead of 'Pick<Exclude<...>>' for object rest #31134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'Omit' instead of 'Pick<Exclude<...>>' for object rest #31134
Conversation
Seems like the change is probably good. Now run |
@DanielRosenwasser , |
Actually, I don't know if the change is appropriate because it will error if |
Mm, team seems to think that maybe we shouldn't even have the fallback. |
@DanielRosenwasser , |
Ok, I can modify the code as follows. if (! omitTypeAlias) {
return errorType;
}
return getTypeAliasInstantiation(omitTypeAlias, [source, omitKeyType]); and get rid of the code from line |
@DanielRosenwasser ,
|
@DanielRosenwasser , |
@typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at cf15c79. You can monitor the build here. It should now contribute to this PR's status checks. |
Trying to deliver the Modification mentioned in #30948
Fixes #30948