Narrow types by satisfies expressions #60782

Andarist · 2024-12-17T08:35:44Z

jakebailey · 2025-01-22T16:26:28Z

typescript-bot · 2025-01-22T16:26:32Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-22T16:49:43Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60782/merge:

Everything looks good!

typescript-bot · 2025-01-22T16:50:10Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-22T17:09:25Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,713k (± 0.80%)}	_{193,175k (± 0.08%)}	_~	_193,090k	_193,491k	_{p=0.108 n=6}
_{Parse Time}	_{1.30s (± 1.06%)}	_{1.31s (± 0.80%)}	_~	_1.29s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.77s (± 0.32%)}	_{9.79s (± 0.39%)}	_~	_9.75s	_9.85s	_{p=0.294 n=6}
_{Emit Time}	_{2.74s (± 0.65%)}	_{2.73s (± 0.82%)}	_~	_2.71s	_2.77s	_{p=0.256 n=6}
_{Total Time}	_{14.54s (± 0.26%)}	_{14.55s (± 0.33%)}	_~	_14.50s	_14.64s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,987	_947,987	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,696k (± 0.00%)}	_{1,225,690k (± 0.00%)}	_~	_1,225,643k	_1,225,731k	_{p=0.936 n=6}
_{Parse Time}	_{6.64s (± 0.66%)}	_{6.67s (± 0.29%)}	_~	_6.64s	_6.70s	_{p=0.406 n=6}
_{Bind Time}	_{1.90s (± 0.62%)}	_{1.89s (± 0.62%)}	_~	_1.88s	_1.91s	_{p=0.365 n=6}
_{Check Time}	_{32.01s (± 0.43%)}	_{31.91s (± 0.36%)}	_~	_31.80s	_32.11s	_{p=0.261 n=6}
_{Emit Time}	_{15.18s (± 0.34%)}	_{15.17s (± 0.40%)}	_~	_15.08s	_15.24s	_{p=0.630 n=6}
_{Total Time}	_{55.73s (± 0.19%)}	_{55.64s (± 0.25%)}	_~	_55.46s	_55.86s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,444,319	_2,444,319	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,761	_896,761	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,302,947k (± 0.00%)}	_{2,302,946k (± 0.00%)}	_~	_2,302,895k	_2,303,002k	_{p=0.936 n=6}
_{Parse Time}	_{8.93s (± 0.11%)}	_{8.94s (± 0.19%)}	_~	_8.92s	_8.97s	_{p=0.157 n=6}
_{Bind Time}	_{2.17s (± 0.54%)}	_{2.19s (± 0.63%)}	_~	_2.17s	_2.21s	_{p=0.121 n=6}
_{Check Time}	_{73.49s (± 0.41%)}	_{73.59s (± 0.56%)}	_~	_73.07s	_74.26s	_{p=0.810 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 4.15%)}	_~	_0.27s	_0.30s	_{p=0.858 n=6}
_{Total Time}	_{84.87s (± 0.36%)}	_{84.99s (± 0.51%)}	_~	_84.48s	_85.71s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,792	_1,228,793	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,906	_266,907	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,360,258k (± 0.02%)}	_{2,360,456k (± 0.02%)}	_~	_2,359,934k	_2,361,154k	_{p=0.575 n=6}
_{Parse Time}	_{5.22s (± 0.88%)}	_{5.23s (± 0.83%)}	_~	_5.18s	_5.30s	_{p=0.688 n=6}
_{Bind Time}	_{1.76s (± 0.36%)}	_{1.78s (± 0.84%)}	_{+0.02s (+ 1.33%)}	_1.76s	_1.80s	_{p=0.019 n=6}
_{Check Time}	_{35.18s (± 0.23%)}	_{35.26s (± 0.31%)}	_~	_35.13s	_35.45s	_{p=0.173 n=6}
_{Emit Time}	_{3.01s (± 1.98%)}	_{3.01s (± 1.09%)}	_~	_2.95s	_3.05s	_{p=0.419 n=6}
_{Total Time}	_{45.18s (± 0.21%)}	_{45.28s (± 0.24%)}	_~	_45.15s	_45.46s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,792	_1,228,793	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,906	_266,907	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,036,058k (± 9.76%)}	_{2,915,600k (±12.85%)}	_~	_2,431,405k	_3,158,493k	_{p=1.000 n=6}
_{Parse Time}	_{6.96s (± 0.99%)}	_{6.90s (± 2.10%)}	_~	_6.70s	_7.07s	_{p=0.575 n=6}
_{Bind Time}	_{2.12s (± 1.22%)}	_{2.15s (± 1.33%)}	_~	_2.11s	_2.19s	_{p=0.126 n=6}
_{Check Time}	_{42.78s (± 0.41%)}	_{42.80s (± 0.25%)}	_~	_42.65s	_42.94s	_{p=1.000 n=6}
_{Emit Time}	_{3.48s (± 2.77%)}	_{3.43s (± 3.19%)}	_~	_3.32s	_3.58s	_{p=0.336 n=6}
_{Total Time}	_{55.34s (± 0.33%)}	_{55.28s (± 0.53%)}	_~	_54.88s	_55.64s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,659	_262,660	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,711	_106,712	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{440,798k (± 0.03%)}	_{440,825k (± 0.02%)}	_~	_440,708k	_440,898k	_{p=0.810 n=6}
_{Parse Time}	_{3.56s (± 0.77%)}	_{3.57s (± 0.82%)}	_~	_3.54s	_3.61s	_{p=0.293 n=6}
_{Bind Time}	_{1.32s (± 1.30%)}	_{1.33s (± 0.56%)}	_~	_1.32s	_1.34s	_{p=0.273 n=6}
_{Check Time}	_{19.09s (± 0.38%)}	_{19.05s (± 0.40%)}	_~	_18.93s	_19.16s	_{p=0.747 n=6}
_{Emit Time}	_{1.52s (± 0.79%)}	_{1.53s (± 0.99%)}	_~	_1.50s	_1.54s	_{p=0.806 n=6}
_{Total Time}	_{25.49s (± 0.31%)}	_{25.48s (± 0.24%)}	_~	_25.39s	_25.54s	_{p=0.628 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,688k (± 0.01%)}	_{371,710k (± 0.05%)}	_~	_371,573k	_372,043k	_{p=0.471 n=6}
_{Parse Time}	_{2.90s (± 1.48%)}	_{2.89s (± 1.11%)}	_~	_2.86s	_2.94s	_{p=0.687 n=6}
_{Bind Time}	_{1.61s (± 1.27%)}	_{1.60s (± 1.57%)}	_~	_1.55s	_1.62s	_{p=0.625 n=6}
_{Check Time}	_{16.46s (± 0.40%)}	_{16.49s (± 0.40%)}	_~	_16.40s	_16.60s	_{p=0.567 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.97s (± 0.54%)}	_{20.98s (± 0.13%)}	_~	_20.95s	_21.01s	_{p=0.934 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,258,890	_3,258,890	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,120,678	_1,120,678	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,333,181k (± 0.01%)}	_{3,333,020k (± 0.01%)}	_~	_3,332,578k	_3,333,531k	_{p=0.689 n=6}
_{Parse Time}	_{14.59s (± 0.67%)}	_{14.56s (± 0.25%)}	_~	_14.52s	_14.62s	_{p=0.936 n=6}
_{Bind Time}	_{4.58s (± 0.30%)}	_{4.59s (± 0.32%)}	_~	_4.57s	_4.61s	_{p=0.120 n=6}
_{Check Time}	_{90.44s (± 2.16%)}	_{90.42s (± 2.09%)}	_~	_88.50s	_92.47s	_{p=1.000 n=6}
_{Emit Time}	_{27.82s (± 3.46%)}	_{28.50s (± 2.82%)}	_~	_27.43s	_29.13s	_{p=0.471 n=6}
_{Total Time}	_{137.42s (± 1.39%)}	_{138.07s (± 1.45%)}	_~	_135.34s	_140.59s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,613	_291,613	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,977	_118,977	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,482k (± 0.03%)}	_{445,322k (± 0.01%)}	_{-160k (- 0.04%)}	_445,252k	_445,408k	_{p=0.008 n=6}
_{Parse Time}	_{5.08s (± 0.81%)}	_{5.05s (± 0.91%)}	_~	_4.99s	_5.10s	_{p=0.170 n=6}
_{Bind Time}	_{2.23s (± 1.41%)}	_{2.22s (± 1.75%)}	_~	_2.16s	_2.28s	_{p=0.745 n=6}
_{Check Time}	_{23.36s (± 0.27%)}	_{23.35s (± 0.26%)}	_~	_23.28s	_23.44s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.68s (± 0.10%)}	_{30.62s (± 0.26%)}	_~	_30.49s	_30.72s	_{p=0.198 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,068	_555,068	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,042k (± 0.01%)}	_{494,018k (± 0.02%)}	_~	_493,784k	_494,069k	_{p=0.297 n=6}
_{Parse Time}	_{3.40s (± 0.40%)}	_{3.42s (± 0.54%)}	_~	_3.38s	_3.43s	_{p=0.156 n=6}
_{Bind Time}	_{1.18s (± 1.24%)}	_{1.18s (± 1.03%)}	_~	_1.16s	_1.19s	_{p=0.564 n=6}
_{Check Time}	_{19.54s (± 0.49%)}	_{19.74s (± 2.10%)}	_~	_19.50s	_20.58s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.13s (± 0.43%)}	_{24.34s (± 1.68%)}	_~	_24.09s	_25.16s	_{p=0.297 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-22T18:03:58Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60782/merge:

Everything looks good!

jakebailey

LGTM; #60778 is marked experience enhancement so this should be good to go.

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 17, 2024

Narrow types by satisfies expressions

6a7ab24

Andarist force-pushed the narrow-type-on-satisfies-expressions branch from f468771 to 6a7ab24 Compare December 17, 2024 09:16

jakebailey approved these changes Jan 22, 2025

View reviewed changes

jakebailey merged commit efe07a0 into microsoft:main Jan 22, 2025
32 checks passed

Andarist deleted the narrow-type-on-satisfies-expressions branch January 22, 2025 22:13

sandersn removed this from PR Backlog Apr 22, 2025

Andarist mentioned this pull request Jun 4, 2025

Port "Narrow types by satisfies expressions" microsoft/typescript-go#1047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Narrow types by satisfies expressions #60782

Narrow types by satisfies expressions #60782

Uh oh!

Andarist commented Dec 17, 2024

Uh oh!

jakebailey commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025

tsc

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

jakebailey left a comment

Uh oh!

Uh oh!

Uh oh!

Narrow types by satisfies expressions #60782

Narrow types by satisfies expressions #60782

Uh oh!

Conversation

Andarist commented Dec 17, 2024

Uh oh!

jakebailey commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

typescript-bot commented Jan 22, 2025

tsc

Uh oh!

typescript-bot commented Jan 22, 2025

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Jan 22, 2025 •

edited

Loading