Circular function expressions #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| // 'private' should not be considered a member variable here. | |||
| private[key] = value; | |||
| ~~~~~~~ | |||
There was a problem hiding this comment.
this is interesting.. why was that missed before?
also the comment seems wrong.
There was a problem hiding this comment.
Previously this error wouldn't be reported because the expression in the return statement isn't type checked if the return statement occurs in a disallowed location. It's not worth the complexity to recompute whether we should skip the function expression body check phase, so the check always occurs.
|
👍 |
1 similar comment
|
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Sep 5, 2014
Circular function expressions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445 and #583.
Function expression bodies are now checked in a separate phase after all statements in the enclosing body to ensure constructs like the following are correctly typed:
Previously we'd perform a full type check of the body of the function expression whilst in the process determining the type of
foowhich would causefooto be given typeanybecause of the recursive reference. With this change,foois now correctly typed as() => string.