Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOM Update 2025-05-02 #61647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DOM Update 2025-05-02 #61647

wants to merge 3 commits into from

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented May 2, 2025

This updates the DOM types to include changes from microsoft/TypeScript-DOM-lib-generator#1944, among others.

Fixes #61480

@rbuckton rbuckton requested review from sandersn and Copilot May 2, 2025 18:46
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog May 2, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DOM types to incorporate changes from the referenced TypeScript-DOM-lib-generator pull request, while ensuring that related error messages and contextual type instantiations continue to behave as expected.

  • Updates baseline errors for instantiateContextualTypes tests
  • Covers new contextual typing scenarios with generic components and reducer patterns
Files not reviewed (6)
  • tests/baselines/reference/collisionThisExpressionAndLocalVarInLambda.types: Language not supported
  • tests/baselines/reference/globalThisBlockscopedProperties.types: Language not supported
  • tests/baselines/reference/instantiateContextualTypes.types: Language not supported
  • tests/baselines/reference/noCollisionThisExpressionAndLocalVarInLambda.types: Language not supported
  • tests/baselines/reference/underscoreTest1.types: Language not supported
  • tests/baselines/reference/unicodeIdentifierName2.types: Language not supported

@rbuckton
Copy link
Member Author

rbuckton commented May 2, 2025

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: jquery.fancytree
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery.fancytree/jquery.fancytree-tests.ts
  74:7  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: w3c-image-capture
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/index.d.ts
   3:15  error  TypeScript@local compile error: 
Duplicate identifier 'ImageCapture'                                                                                                                                         @definitelytyped/expect
  18:14  error  TypeScript@local compile error: 
All declarations of 'redEyeReduction' must have identical modifiers                                                                                                         @definitelytyped/expect
  18:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'redEyeReduction' must be of type 'RedEyeReduction | undefined', but here has type 'RedEyeReduction'    @definitelytyped/expect
  19:14  error  TypeScript@local compile error: 
All declarations of 'imageHeight' must have identical modifiers                                                                                                             @definitelytyped/expect
  19:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'imageHeight' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange'  @definitelytyped/expect
  20:14  error  TypeScript@local compile error: 
All declarations of 'imageWidth' must have identical modifiers                                                                                                              @definitelytyped/expect
  20:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'imageWidth' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange'   @definitelytyped/expect
  21:14  error  TypeScript@local compile error: 
All declarations of 'fillLightMode' must have identical modifiers                                                                                                           @definitelytyped/expect
  21:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'fillLightMode' must be of type 'FillLightMode[] | undefined', but here has type 'FillLightMode[]'      @definitelytyped/expect
  32:14  error  TypeScript@local compile error: 
All declarations of 'max' must have identical modifiers                                                                                                                     @definitelytyped/expect
  32:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'max' must be of type 'number | undefined', but here has type 'number'                                  @definitelytyped/expect
  33:14  error  TypeScript@local compile error: 
All declarations of 'min' must have identical modifiers                                                                                                                     @definitelytyped/expect
  33:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'min' must be of type 'number | undefined', but here has type 'number'                                  @definitelytyped/expect
  34:14  error  TypeScript@local compile error: 
All declarations of 'step' must have identical modifiers                                                                                                                    @definitelytyped/expect
  34:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'step' must be of type 'number | undefined', but here has type 'number'                                 @definitelytyped/expect
  37:6   error  TypeScript@local compile error: 
Duplicate identifier 'RedEyeReduction'                                                                                                                                      @definitelytyped/expect
  38:6   error  TypeScript@local compile error: 
Duplicate identifier 'FillLightMode'                                                                                                                                        @definitelytyped/expect
  88:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'whiteBalanceMode' must be of type 'string | undefined', but here has type 'MeteringMode | undefined'   @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/w3c-image-capture-tests.ts
   24:29  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   25:29  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   26:30  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   68:26  error  TypeScript@local compile error: 
Property 'grabFrame' does not exist on type 'ImageCapture'  @definitelytyped/expect
   70:24  error  TypeScript@local compile error: 
Parameter 'err' implicitly has an 'any' type                @definitelytyped/expect
  103:22  error  TypeScript@local compile error: 
Property 'grabFrame' does not exist on type 'ImageCapture'  @definitelytyped/expect
  105:20  error  TypeScript@local compile error: 
Parameter 'err' implicitly has an 'any' type                @definitelytyped/expect
  158:21  error  TypeScript@local compile error: 
'capabilities.focusDistance.min' is possibly 'undefined'    @definitelytyped/expect
  159:21  error  TypeScript@local compile error: 
'capabilities.focusDistance.max' is possibly 'undefined'    @definitelytyped/expect
  160:22  error  TypeScript@local compile error: 
'capabilities.focusDistance.step' is possibly 'undefined'   @definitelytyped/expect

✖ 28 problems (28 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: summernote
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/summernote/summernote-tests.ts
  36:7  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: node
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/node/test/globals-dom.ts
  63:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<Uint8Array> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>  @definitelytyped/expect
  64:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>         @definitelytyped/expect
  65:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>         @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: ckeditor4
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/ckeditor4/ckeditor4-tests.ts
   20:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  115:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  134:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  139:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  142:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  143:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  145:11  error  TypeScript@local compile error: 
Argument of type 'unknown' is not assignable to parameter of type 'string | undefined'          @definitelytyped/expect
  146:11  error  TypeScript@local compile error: 
Argument of type 'unknown' is not assignable to parameter of type 'string | undefined'          @definitelytyped/expect
  158:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  192:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  194:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  195:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  197:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  198:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  199:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  200:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  201:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  227:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  257:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  258:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  259:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  260:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  264:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  265:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  286:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  298:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  325:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  335:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  337:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  340:11  error  TypeScript@local compile error: 
Argument of type '{ [key: string]: unknown; }' is not assignable to parameter of type 'string'  @definitelytyped/expect
  342:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  344:11  error  TypeScript@local compile error: 
Argument of type 'document' is not assignable to parameter of type 'string'                     @definitelytyped/expect
  346:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  439:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  440:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  442:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  443:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect

✖ 37 problems (37 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: dropboxjs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dropboxjs/dropboxjs-tests.ts
  16:19  error  TypeScript@local compile error: 
Argument of type 'ApiError' is not assignable to parameter of type 'string'  @definitelytyped/expect
  24:19  error  TypeScript@local compile error: 
Argument of type 'ApiError' is not assignable to parameter of type 'string'  @definitelytyped/expect
  32:19  error  TypeScript@local compile error: 
Argument of type 'ApiError' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: microsoft-ajax
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/microsoft-ajax/microsoft-ajax-tests.ts
  782:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  786:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  791:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: photoswipe
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/photoswipe/photoswipe-tests.ts
  140:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect
  145:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  146:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  147:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: hashset
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/hashset/hashset-tests.ts
  21:7  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect
  32:7  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  33:7  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  34:7  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: codemirror
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/codemirror/test/addon/tern/tern.ts
  13:15  error  TypeScript@local compile error: 
Argument of type 'string | Error' is not assignable to parameter of type 'string | undefined'.
  Type 'Error' is not assignable to type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: signals
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/signals/signals-tests.ts
   43:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect
   52:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect
   61:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'   @definitelytyped/expect
  165:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  175:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  176:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: chrome
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/chrome/test/index.ts
  3009:89  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: react-swipe
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react-swipe/react-swipe-tests.tsx
  28:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: snapsvg
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/snapsvg/test/3.ts
  12:11  error  TypeScript@local compile error: 
Argument of type 'BBox' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: jquery/v1
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery/v1/jquery-tests.ts
  1637:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'        @definitelytyped/expect
  1896:11  error  TypeScript@local compile error: 
Argument of type 'HTMLElement[]' is not assignable to parameter of type 'string'  @definitelytyped/expect
  1899:11  error  TypeScript@local compile error: 
Argument of type 'HTMLElement' is not assignable to parameter of type 'string'    @definitelytyped/expect
  2505:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'        @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: jquery/v2
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery/v2/jquery-tests.ts
  1636:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'    @definitelytyped/expect
  1898:11  error  TypeScript@local compile error: 
Argument of type 'Element[]' is not assignable to parameter of type 'string'  @definitelytyped/expect
  1901:11  error  TypeScript@local compile error: 
Argument of type 'Element' is not assignable to parameter of type 'string'    @definitelytyped/expect
  2507:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'    @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: jquery
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/example-tests.ts
  1488:19  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  1516:19  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  1518:19  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  2966:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  4113:19  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/jquery/test/longdesc-tests.ts
   471:15  error  TypeScript@local compile error: 
Argument of type 'PlainObject<any>' is not assignable to parameter of type 'string'  @definitelytyped/expect
   505:15  error  TypeScript@local compile error: 
Argument of type 'PlainObject<any>' is not assignable to parameter of type 'string'  @definitelytyped/expect
  1692:19  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'            @definitelytyped/expect
  1698:19  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'            @definitelytyped/expect
  2364:15  error  TypeScript@local compile error: 
Argument of type 'HTMLElement[]' is not assignable to parameter of type 'string'     @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: jquery-touchswipe
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery-touchswipe/jquery-touchswipe-tests.ts
  560:15  error  TypeScript@local compile error: 
Argument of type 'number | JQuery<HTMLElement>' is not assignable to parameter of type 'string | undefined'.
  Type 'number' is not assignable to type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: phonegap
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/phonegap/phonegap-tests.ts
  605:15  error  TypeScript@local compile error: 
Argument of type 'Event' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: three
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/three/test/integration/three-examples/webgl2_rendertarget_texture2darray.ts
  144:52  error  TypeScript@local compile error: 
Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource | null | undefined'.
  Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
    Types of property 'buffer' are incompatible.
      Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
        Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
          Types of property '[Symbol.toStringTag]' are incompatible.
            Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/three/test/unit/examples/jsm/exporters/STLExporter.ts
  15:21  error  TypeScript@local compile error: 
Argument of type 'DataView<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'.
  Type 'DataView<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
    Types of property 'buffer' are incompatible.
      Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
        Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
          Types of property '[Symbol.toStringTag]' are incompatible.
            Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: less
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/less/less-tests.ts
  33:15  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: lscache
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/lscache/lscache-tests.ts
   2:7   error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  23:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: switchery
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/switchery/switchery-tests.ts
  53:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect
  61:15  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61647/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

effect

tsconfig.json

tsconfig.build.json

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 194,190k (± 0.98%) 194,172k (± 0.96%) ~ 192,949k 196,594k p=0.689 n=6
Parse Time 1.30s (± 0.75%) 1.30s (± 0.64%) ~ 1.29s 1.31s p=0.588 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.74s (± 0.35%) 9.76s (± 0.20%) ~ 9.75s 9.80s p=0.145 n=6
Emit Time 2.72s (± 0.76%) 2.73s (± 0.30%) ~ 2.72s 2.74s p=0.934 n=6
Total Time 14.49s (± 0.34%) 14.52s (± 0.11%) ~ 14.51s 14.55s p=0.196 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,670 949,240 +570 (+ 0.06%) ~ ~ p=0.001 n=6
Types 410,947 411,065 +118 (+ 0.03%) ~ ~ p=0.001 n=6
Memory used 1,224,331k (± 0.00%) 1,225,107k (± 0.00%) +776k (+ 0.06%) 1,225,077k 1,225,162k p=0.005 n=6
Parse Time 6.64s (± 1.05%) 6.62s (± 0.80%) ~ 6.55s 6.69s p=0.418 n=6
Bind Time 1.89s (± 0.40%) 1.89s (± 0.27%) ~ 1.88s 1.89s p=0.784 n=6
Check Time 31.90s (± 0.29%) 31.95s (± 0.17%) ~ 31.89s 32.02s p=0.227 n=6
Emit Time 15.24s (± 0.42%) 15.22s (± 0.51%) ~ 15.10s 15.32s p=0.689 n=6
Total Time 55.67s (± 0.24%) 55.68s (± 0.24%) ~ 55.53s 55.91s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,361,667 2,361,873 +206 (+ 0.01%) ~ ~ p=0.001 n=6
Types 868,625 868,652 +27 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,317,097k (± 0.00%) 2,317,547k (± 0.00%) +450k (+ 0.02%) 2,317,523k 2,317,590k p=0.005 n=6
Parse Time 8.74s (± 0.35%) 8.76s (± 0.29%) ~ 8.72s 8.79s p=0.280 n=6
Bind Time 2.20s (± 0.57%) 2.23s (± 0.74%) +0.03s (+ 1.14%) 2.20s 2.24s p=0.040 n=6
Check Time 69.81s (± 0.43%) 69.95s (± 0.28%) ~ 69.74s 70.27s p=0.298 n=6
Emit Time 0.30s (± 2.98%) 0.30s (± 2.52%) ~ 0.29s 0.31s p=0.798 n=6
Total Time 81.05s (± 0.36%) 81.23s (± 0.23%) ~ 81.04s 81.53s p=0.199 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,044 1,228,044 ~ ~ ~ p=1.000 n=6
Types 267,260 267,260 ~ ~ ~ p=1.000 n=6
Memory used 2,360,689k (± 0.02%) 2,360,829k (± 0.02%) ~ 2,360,146k 2,361,450k p=0.689 n=6
Parse Time 5.20s (± 1.21%) 5.23s (± 0.90%) ~ 5.16s 5.30s p=0.423 n=6
Bind Time 1.80s (± 0.98%) 1.80s (± 0.98%) ~ 1.78s 1.82s p=0.871 n=6
Check Time 35.36s (± 0.39%) 35.42s (± 0.18%) ~ 35.33s 35.52s p=0.689 n=6
Emit Time 3.02s (± 2.50%) 2.97s (± 1.85%) ~ 2.89s 3.04s p=0.423 n=6
Total Time 45.37s (± 0.09%) 45.42s (± 0.18%) ~ 45.29s 45.53s p=0.173 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,044 1,228,044 ~ ~ ~ p=1.000 n=6
Types 267,260 267,260 ~ ~ ~ p=1.000 n=6
Memory used 3,037,474k (± 9.77%) 3,038,103k (± 9.77%) ~ 2,431,342k 3,160,491k p=0.298 n=6
Parse Time 6.97s (± 1.02%) 6.94s (± 1.48%) ~ 6.78s 7.10s p=0.575 n=6
Bind Time 2.17s (± 2.40%) 2.15s (± 1.85%) ~ 2.10s 2.21s p=0.810 n=6
Check Time 42.93s (± 0.60%) 42.98s (± 0.47%) ~ 42.73s 43.17s p=0.748 n=6
Emit Time 3.51s (± 1.66%) 3.54s (± 1.77%) ~ 3.47s 3.62s p=0.378 n=6
Total Time 55.58s (± 0.55%) 55.61s (± 0.46%) ~ 55.20s 55.89s p=1.000 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,411 263,411 ~ ~ ~ p=1.000 n=6
Types 107,096 107,096 ~ ~ ~ p=1.000 n=6
Memory used 441,738k (± 0.02%) 441,825k (± 0.02%) ~ 441,720k 441,913k p=0.066 n=6
Parse Time 3.52s (± 0.53%) 3.55s (± 0.58%) ~ 3.53s 3.58s p=0.121 n=6
Bind Time 1.32s (± 0.57%) 1.32s (± 0.31%) ~ 1.31s 1.32s p=1.000 n=6
Check Time 18.96s (± 0.22%) 18.95s (± 0.40%) ~ 18.86s 19.07s p=0.419 n=6
Emit Time 1.53s (± 0.92%) 1.54s (± 1.16%) ~ 1.51s 1.56s p=0.289 n=6
Total Time 25.33s (± 0.18%) 25.35s (± 0.29%) ~ 25.24s 25.42s p=0.746 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,981 225,981 ~ ~ ~ p=1.000 n=6
Types 94,356 94,356 ~ ~ ~ p=1.000 n=6
Memory used 371,461k (± 0.06%) 371,351k (± 0.06%) ~ 371,143k 371,790k p=0.471 n=6
Parse Time 2.89s (± 1.40%) 2.88s (± 0.90%) ~ 2.85s 2.91s p=0.688 n=6
Bind Time 1.59s (± 1.02%) 1.59s (± 1.30%) ~ 1.57s 1.62s p=0.935 n=6
Check Time 16.51s (± 0.48%) 16.48s (± 0.27%) ~ 16.43s 16.56s p=0.872 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 20.99s (± 0.59%) 20.96s (± 0.14%) ~ 20.92s 20.99s p=0.872 n=6
vscode - node (v18.15.0, x64)
Errors 4 19 🔻+15 (+375.00%) ~ ~ p=0.001 n=6
Symbols 3,391,657 3,393,646 +1,989 (+ 0.06%) ~ ~ p=0.001 n=6
Types 1,148,598 1,149,028 +430 (+ 0.04%) ~ ~ p=0.001 n=6
Memory used 3,443,255k (± 0.01%) 3,444,660k (± 0.01%) +1,405k (+ 0.04%) 3,444,064k 3,444,907k p=0.005 n=6
Parse Time 14.72s (± 0.38%) 14.73s (± 0.42%) ~ 14.66s 14.82s p=1.000 n=6
Bind Time 4.72s (± 0.35%) 4.76s (± 1.00%) ~ 4.70s 4.82s p=0.226 n=6
Check Time 92.86s (± 1.44%) 92.91s (± 1.92%) ~ 91.61s 96.48s p=1.000 n=6
Emit Time 29.96s (± 2.03%) 30.02s (± 1.82%) ~ 29.68s 31.13s p=0.378 n=6
Total Time 142.25s (± 1.37%) 142.42s (± 1.64%) ~ 140.74s 147.13s p=0.873 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 317,345 317,567 +222 (+ 0.07%) ~ ~ p=0.001 n=6
Types 140,331 140,470 +139 (+ 0.10%) ~ ~ p=0.001 n=6
Memory used 472,437k (± 0.02%) 472,941k (± 0.01%) +504k (+ 0.11%) 472,880k 473,025k p=0.005 n=6
Parse Time 5.20s (± 0.29%) 5.17s (± 0.57%) ~ 5.13s 5.22s p=0.075 n=6
Bind Time 2.26s (± 0.88%) 2.24s (± 0.46%) ~ 2.23s 2.26s p=0.162 n=6
Check Time 25.87s (± 0.60%) 25.91s (± 0.08%) ~ 25.88s 25.94s p=0.630 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 33.33s (± 0.44%) 33.32s (± 0.09%) ~ 33.29s 33.36s p=0.378 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 570,517 570,733 +216 (+ 0.04%) ~ ~ p=0.001 n=6
Types 191,417 191,446 +29 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 500,889k (± 0.03%) 501,299k (± 0.01%) +410k (+ 0.08%) 501,220k 501,392k p=0.005 n=6
Parse Time 4.30s (± 0.38%) 4.32s (± 0.59%) ~ 4.28s 4.36s p=0.190 n=6
Bind Time 1.52s (± 1.70%) 1.53s (± 1.20%) ~ 1.50s 1.55s p=0.567 n=6
Check Time 25.13s (± 1.62%) 24.88s (± 0.18%) -0.25s (- 0.98%) 24.82s 24.94s p=0.024 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.96s (± 1.28%) 30.74s (± 0.21%) ~ 30.64s 30.80s p=0.109 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@rbuckton
Copy link
Member Author

rbuckton commented May 2, 2025

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61647/merge:

Something interesting changed - please have a look.

Details

actualbudget/actual

1 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/loot-core/tsconfig.api.json

adobe/react-spectrum

10 of 15 projects failed to build with the old tsc and were ignored

examples/rsp-cra-18/tsconfig.json

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2322: Type 'typeof TextEncoder' is not assignable to type '{ new (): TextEncoder; prototype: TextEncoder; }'.
  • error TS2322: Type 'import("stream/web").ReadableStreamDefaultReader<ObservableEvent<T>>' is not assignable to type 'ReadableStreamDefaultReader<ObservableEvent<T>>'.

src/tsconfig.json

  • error TS2322: Type 'typeof TextEncoder' is not assignable to type '{ new (): TextEncoder; prototype: TextEncoder; }'.
  • error TS2322: Type 'import("stream/web").ReadableStreamDefaultReader<ObservableEvent<T>>' is not assignable to type 'ReadableStreamDefaultReader<ObservableEvent<T>>'.

better-auth/better-auth

15 of 17 projects failed to build with the old tsc and were ignored

packages/better-auth/tsconfig.declarations.json

FlowiseAI/Flowise

1 of 3 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.json

hoppscotch/hoppscotch

10 of 18 projects failed to build with the old tsc and were ignored

packages/hoppscotch-kernel/tsconfig.json

packages/hoppscotch-kernel/tsconfig.decl.json

immich-app/immich

3 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

ionic-team/ionic-framework

24 of 25 projects failed to build with the old tsc and were ignored

core/tsconfig.json

labring/FastGPT

7 of 12 projects failed to build with the old tsc and were ignored

projects/app/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/notebook-renderers/tsconfig.json

shoelace-style/shoelace

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.prod.json

signalapp/Signal-Desktop

1 of 2 projects failed to build with the old tsc and were ignored

sticker-creator/tsconfig.json

socketio/socket.io

13 of 32 projects failed to build with the old tsc and were ignored

packages/engine.io-parser/tsconfig.json

packages/engine.io-parser/tsconfig.esm.json

t3-oss/create-t3-app

1 of 5 projects failed to build with the old tsc and were ignored

www/tsconfig.json

  • error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BodyInit | null | undefined'.

Tonejs/Tone.js

1 of 2 projects failed to build with the old tsc and were ignored

scripts/tsconfig.build.json

tremorlabs/tremor-npm

tsconfig.json

trpc/trpc

37 of 43 projects failed to build with the old tsc and were ignored

packages/tests/tsconfig.json

packages/tanstack-react-query/tsconfig.json

packages/next/tsconfig.json

packages/client/tsconfig.json

@jakebailey
Copy link
Member

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

FYI @saschanaz @Bashamega

@rbuckton
Copy link
Member Author

rbuckton commented May 2, 2025

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
run dt ✅ Started

@rbuckton
Copy link
Member Author

rbuckton commented May 2, 2025

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 2, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
run dt ✅ Started 👀 Results

@saschanaz
Copy link
Contributor

A large number of failures seem to be due to the signature of alert() changing in the output from TypeScript-DOM-lib-generator

FYI @saschanaz @Bashamega

Any idea what the failure looks like?

@saschanaz
Copy link
Contributor

Err, okay, alert(number). Oh no.

@saschanaz
Copy link
Contributor

saschanaz commented May 2, 2025

I guess we should backout the PR. I thought nobody would do this... 😅

@saschanaz
Copy link
Contributor

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: w3c-image-capture
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/index.d.ts
   3:15  error  TypeScript@local compile error: 
Duplicate identifier 'ImageCapture'                                                                                                                                         @definitelytyped/expect
  18:14  error  TypeScript@local compile error: 
All declarations of 'redEyeReduction' must have identical modifiers                                                                                                         @definitelytyped/expect
  18:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'redEyeReduction' must be of type 'RedEyeReduction | undefined', but here has type 'RedEyeReduction'    @definitelytyped/expect
  19:14  error  TypeScript@local compile error: 
All declarations of 'imageHeight' must have identical modifiers                                                                                                             @definitelytyped/expect
  19:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'imageHeight' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange'  @definitelytyped/expect
  20:14  error  TypeScript@local compile error: 
All declarations of 'imageWidth' must have identical modifiers                                                                                                              @definitelytyped/expect
  20:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'imageWidth' must be of type 'MediaSettingsRange | undefined', but here has type 'MediaSettingsRange'   @definitelytyped/expect
  21:14  error  TypeScript@local compile error: 
All declarations of 'fillLightMode' must have identical modifiers                                                                                                           @definitelytyped/expect
  21:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'fillLightMode' must be of type 'FillLightMode[] | undefined', but here has type 'FillLightMode[]'      @definitelytyped/expect
  32:14  error  TypeScript@local compile error: 
All declarations of 'max' must have identical modifiers                                                                                                                     @definitelytyped/expect
  32:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'max' must be of type 'number | undefined', but here has type 'number'                                  @definitelytyped/expect
  33:14  error  TypeScript@local compile error: 
All declarations of 'min' must have identical modifiers                                                                                                                     @definitelytyped/expect
  33:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'min' must be of type 'number | undefined', but here has type 'number'                                  @definitelytyped/expect
  34:14  error  TypeScript@local compile error: 
All declarations of 'step' must have identical modifiers                                                                                                                    @definitelytyped/expect
  34:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'step' must be of type 'number | undefined', but here has type 'number'                                 @definitelytyped/expect
  37:6   error  TypeScript@local compile error: 
Duplicate identifier 'RedEyeReduction'                                                                                                                                      @definitelytyped/expect
  38:6   error  TypeScript@local compile error: 
Duplicate identifier 'FillLightMode'                                                                                                                                        @definitelytyped/expect
  88:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'whiteBalanceMode' must be of type 'string | undefined', but here has type 'MeteringMode | undefined'   @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/w3c-image-capture/w3c-image-capture-tests.ts
   24:29  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   25:29  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   26:30  error  TypeScript@local compile error: 
Object is possibly 'undefined'                              @definitelytyped/expect
   68:26  error  TypeScript@local compile error: 
Property 'grabFrame' does not exist on type 'ImageCapture'  @definitelytyped/expect
   70:24  error  TypeScript@local compile error: 
Parameter 'err' implicitly has an 'any' type                @definitelytyped/expect
  103:22  error  TypeScript@local compile error: 
Property 'grabFrame' does not exist on type 'ImageCapture'  @definitelytyped/expect
  105:20  error  TypeScript@local compile error: 
Parameter 'err' implicitly has an 'any' type                @definitelytyped/expect
  158:21  error  TypeScript@local compile error: 
'capabilities.focusDistance.min' is possibly 'undefined'    @definitelytyped/expect
  159:21  error  TypeScript@local compile error: 
'capabilities.focusDistance.max' is possibly 'undefined'    @definitelytyped/expect
  160:22  error  TypeScript@local compile error: 
'capabilities.focusDistance.step' is possibly 'undefined'   @definitelytyped/expect

✖ 28 problems (28 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: node
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/node/test/globals-dom.ts
  63:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<Uint8Array> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>  @definitelytyped/expect
  64:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>         @definitelytyped/expect
  65:5  error  TypeScript@local tsconfig.dom.json, local tsconfig.webworker.json expected type to be:
  ReadableStream<any> || ReadableStream<Uint8Array<ArrayBufferLike>>
got:
  ReadableStream<Uint8Array<ArrayBuffer>>         @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: three
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/three/test/integration/three-examples/webgl2_rendertarget_texture2darray.ts
  144:52  error  TypeScript@local compile error: 
Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource | null | undefined'.
  Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
    Types of property 'buffer' are incompatible.
      Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
        Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
          Types of property '[Symbol.toStringTag]' are incompatible.
            Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/three/test/unit/examples/jsm/exporters/STLExporter.ts
  15:21  error  TypeScript@local compile error: 
Argument of type 'DataView<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'.
  Type 'DataView<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
    Types of property 'buffer' are incompatible.
      Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
        Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
          Types of property '[Symbol.toStringTag]' are incompatible.
            Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides ArrayBufferLike, it's almost all additions. Plus tonnes of comment changes.

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog May 2, 2025
@Bashamega
Copy link

Should we rollback that PR @saschanaz

@saschanaz
Copy link
Contributor

#61647 (comment)

@stwlam
Copy link

stwlam commented May 3, 2025

Should "click" and several other event types not also be changed from MouseEvent to PointerEvent?

@rbuckton
Copy link
Member Author

rbuckton commented May 5, 2025

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

See #61647 (comment). A large percentage of the DT tests failures are due to the signature of alert() changing.

@rbuckton rbuckton force-pushed the dom-update-2025-05-02 branch from 1fd8451 to 846c7dc Compare May 5, 2025 21:39
@saschanaz
Copy link
Contributor

saschanaz commented May 5, 2025

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

See #61647 (comment). A large percentage of the DT tests failures are due to the signature of alert() changing.

I don't see any match of alert there, what am I missing?

@rbuckton
Copy link
Member Author

rbuckton commented May 5, 2025

Actually I'm talking about https://github.com/microsoft/TypeScript/actions/runs/14803024546/job/41565917783?pr=61647, but that's just an internal test?

See #61647 (comment). A large percentage of the DT tests failures are due to the signature of alert() changing.

I don't see any match of alert there, what am I missing?

Package: ckeditor4
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/ckeditor4/ckeditor4-tests.ts
   20:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  115:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  134:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  139:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  142:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  143:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  145:11  error  TypeScript@local compile error: 
Argument of type 'unknown' is not assignable to parameter of type 'string | undefined'          @definitelytyped/expect
  146:11  error  TypeScript@local compile error: 
Argument of type 'unknown' is not assignable to parameter of type 'string | undefined'          @definitelytyped/expect
  158:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  192:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
  194:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  195:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  197:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  198:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  199:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  200:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  201:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  227:11  error  TypeScript@local compile error: 
Argument of type 'boolean' is not assignable to parameter of type 'string'                      @definitelytyped/expect
  257:11  error  TypeScript@local compile error: 
Argument of type 'number' is not assignable to parameter of type 'string'                       @definitelytyped/expect
...

@saschanaz
Copy link
Contributor

Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout.

@rbuckton
Copy link
Member Author

rbuckton commented May 5, 2025

Ah, the "is not assignable to parameter of type 'string'" errors. Err, still looks like something TS test specific, but perhaps also maybe an early smoke of something bigger. I'm open to backout.

There are similar errors in the user tests, though not as frequent.

@rbuckton
Copy link
Member Author

rbuckton commented May 5, 2025

@typescript-bot run dt
@typescript-bot test top400
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 5, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
run dt ✅ Started ✅ Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61647/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Timeout"

Otherwise...

Something interesting changed - please have a look.

Details

effect

tsconfig.json

tsconfig.build.json

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61647/merge:

Something interesting changed - please have a look.

Details

actualbudget/actual

1 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

packages/loot-core/tsconfig.api.json

apollographql/apollo-client

1 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2322: Type 'typeof TextEncoder' is not assignable to type '{ new (): TextEncoder; prototype: TextEncoder; }'.
  • error TS2322: Type 'import("stream/web").ReadableStreamDefaultReader<ObservableEvent<T>>' is not assignable to type 'ReadableStreamDefaultReader<ObservableEvent<T>>'.

src/tsconfig.json

  • error TS2322: Type 'typeof TextEncoder' is not assignable to type '{ new (): TextEncoder; prototype: TextEncoder; }'.
  • error TS2322: Type 'import("stream/web").ReadableStreamDefaultReader<ObservableEvent<T>>' is not assignable to type 'ReadableStreamDefaultReader<ObservableEvent<T>>'.

better-auth/better-auth

15 of 17 projects failed to build with the old tsc and were ignored

packages/better-auth/tsconfig.declarations.json

FlowiseAI/Flowise

1 of 3 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.json

hoppscotch/hoppscotch

10 of 18 projects failed to build with the old tsc and were ignored

packages/hoppscotch-kernel/tsconfig.json

packages/hoppscotch-kernel/tsconfig.decl.json

immich-app/immich

3 of 7 projects failed to build with the old tsc and were ignored

server/tsconfig.build.json

ionic-team/ionic-framework

24 of 25 projects failed to build with the old tsc and were ignored

core/tsconfig.json

labring/FastGPT

7 of 12 projects failed to build with the old tsc and were ignored

projects/app/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/notebook-renderers/tsconfig.json

shoelace-style/shoelace

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.prod.json

signalapp/Signal-Desktop

1 of 2 projects failed to build with the old tsc and were ignored

sticker-creator/tsconfig.json

socketio/socket.io

13 of 32 projects failed to build with the old tsc and were ignored

packages/engine.io-parser/tsconfig.json

packages/engine.io-parser/tsconfig.esm.json

t3-oss/create-t3-app

1 of 5 projects failed to build with the old tsc and were ignored

www/tsconfig.json

  • error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'BodyInit | null | undefined'.

Tonejs/Tone.js

1 of 2 projects failed to build with the old tsc and were ignored

scripts/tsconfig.build.json

trpc/trpc

37 of 43 projects failed to build with the old tsc and were ignored

packages/tests/tsconfig.json

packages/tanstack-react-query/tsconfig.json

packages/next/tsconfig.json

packages/client/tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Needs merge
Development

Successfully merging this pull request may close these issues.

AllowSharedBufferSource definition is incorrect
7 participants