VCD2 - #4
Open
Babak (babaknaderi) wants to merge 4 commits into
Open
VCD2#4Babak (babaknaderi) wants to merge 4 commits into
Babak (babaknaderi) wants to merge 4 commits into
Conversation
- Update README with VCD2 section (839 clips, FFV1 lossless) and VCD2-Benchmarking subset (120 clips) - Add download scripts (bash + Python with parallel download support) - Add file lists for raw MKV (839) and benchmarking MKV (120) - Add VCD2 thumbnail atlas and SI/TI images for TH, TH-BB, TH-BR groups - Add VFR note explaining CFR correction for benchmarking subset Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Babak (babaknaderi)
requested review from
Ross Cutler (rosscutler)
and
a lite review from Copilot
August 18, 2026 11:19
There was a problem hiding this comment.
Pull request overview
This PR adds documentation and download tooling for the new VCD2 camera-native talking-head dataset while modernizing the existing VCD (VCD1) download scripts (bash + Python) and support guidance.
Changes:
- Document VCD2 (dataset summary, citation, download instructions, metadata, scenarios) and refresh the top-level README.
- Add VCD2 download tooling (bash scripts, Python parallel downloader, file manifests) under
download/vcd2. - Improve VCD1 download tooling by updating the Python downloader and hardening bash scripts (retries/resume/partial cleanup), plus update
SUPPORT.md.
Reviewed changes
Copilot reviewed 12 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SUPPORT.md | Replaces template placeholder content with concrete issue/support guidance. |
| README.md | Documents VCD2 + benchmarking subset, adds download + metadata + scenario notes, keeps VCD1 section. |
| download/vcd2/requirements.txt | Adds Python dependency list for VCD2 downloader. |
| download/vcd2/raw_mkv_list.txt | Adds VCD2 raw dataset manifest (838 MKV paths). |
| download/vcd2/benchmarking_mkv_list.txt | Adds VCD2 benchmarking subset manifest (120 MKV paths). |
| download/vcd2/downloader.py | Adds a parallel Python downloader with retries and partial-download cleanup. |
| download/vcd2/download-vcd2-raw-mkv.sh | Adds bash downloader for VCD2 raw dataset (retry + resume + .part). |
| download/vcd2/download-vcd2-benchmarking-mkv.sh | Adds bash downloader for VCD2 benchmarking subset (retry + resume + .part). |
| download/requirements.txt | Simplifies requirements list (drops stdlib argparse). |
| download/downloader.py | Replaces VCD1 downloader with a more robust version (retries, .part, size validation). |
| download/download-vcd1-yuv.sh | Updates VCD1 YUV downloader to use safer bash defaults and retry/resume behavior. |
| download/download-vcd1-mp4.sh | Updates VCD1 MP4 downloader to use safer bash defaults and retry/resume behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+88
to
+95
| lines = [ | ||
| line.strip() | ||
| for line in file_list.read_text(encoding="utf-8-sig").splitlines() | ||
| if line.strip() | ||
| ] | ||
| if len(lines) != len(set(lines)): | ||
| raise ValueError(f"{file_list} contains duplicate paths") | ||
|
|
Comment on lines
+31
to
+38
| paths = [ | ||
| line.strip() | ||
| for line in file_list.read_text(encoding="utf-8-sig").splitlines() | ||
| if line.strip() | ||
| ] | ||
| if len(paths) != len(set(paths)): | ||
| raise ValueError(f"{file_list} contains duplicate paths") | ||
|
|
Comment on lines
+16
to
+20
| BLOB="${BLOB%$'\r'}" | ||
| [ -z "$BLOB" ] && continue | ||
| URL="$AZURE_URL/$BLOB" | ||
| DES="$OUT_DIR/$BLOB" | ||
| TMP="$DES.part" |
Comment on lines
+16
to
+20
| BLOB="${BLOB%$'\r'}" | ||
| [ -z "$BLOB" ] && continue | ||
| URL="$AZURE_URL/$BLOB" | ||
| DES="$OUT_DIR/$BLOB" | ||
| TMP="$DES.part" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the VCD2 camera-native talking-head dataset and update the existing VCD download tooling and documentation.
Changes
Dataset details