Thanks to visit codestin.com
Credit goes to github.com

Skip to content

.NET: Add Executor RouteBuilder Unit Tests#5824

Merged
lokitoth merged 9 commits into
mainfrom
copilot/add-unit-tests-workflows-routebuilder
May 14, 2026
Merged

.NET: Add Executor RouteBuilder Unit Tests#5824
lokitoth merged 9 commits into
mainfrom
copilot/add-unit-tests-workflows-routebuilder

Conversation

Copilot AI commented May 13, 2026 •
edited by lokitoth
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

This PR adds comprehensive unit tests for the RouteBuilder class in the Workflows library and includes several related fixes and cleanups discovered during the process.

Description

New RouteBuilder Unit Tests (RouteBuilderTests.cs)

  • Tests all 8 handler overloads (sync/async × void/result × with/without CancellationToken) via HandlerOverload enum
  • Tests all 8 catch-all fallback routing variants using PortableValue
  • Tests port handler registration, request posting, response routing, and unknown-port failure handling
  • Tests registration semantics: duplicate rejection, overwrite behavior, and PortableValue type guard

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI and others added 6 commits May 13, 2026 18:59
@lokitoth
Add RouteBuilder unit tests
9ca8ef5 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b

Co-authored-by: lokitoth <[email protected]>
@lokitoth
Address RouteBuilder test review feedback
224d9ce 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b

Co-authored-by: lokitoth <[email protected]>
@lokitoth
Fix RouteBuilder test nullability warning
2b66bad 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b

Co-authored-by: lokitoth <[email protected]>
@lokitoth
Refine RouteBuilder test helpers
e59b932 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/012f3b3b-acb9-4869-9084-b767cbe1885b

Co-authored-by: lokitoth <[email protected]>
@lokitoth
Refactor overload int constants to HandlerOverload enum
1a6e443 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/19397f58-a88a-41cf-bd85-588f520e0d0f

Co-authored-by: lokitoth <[email protected]>
@lokitoth
Fix ValueTask compatibility with .NET Framework 4.7.2
53787a3 
Agent-Logs-Url: https://github.com/microsoft/agent-framework/sessions/a8437809-0898-43a6-a950-09eb3417f58a

Co-authored-by: lokitoth <[email protected]>
Copilot AI review requested due to automatic review settings May 13, 2026 19:26
Copilot AI removed the request for review from Copilot May 13, 2026 19:26
@lokitoth lokitoth changed the title Add RouteBuilder unit tests with readable HandlerOverload enum Add Executor RouteBuilder Unit Tests May 13, 2026
@moonbox3 moonbox3 added the .NET Usage: [Issues, PRs], Target: .Net label May 13, 2026
@github-actions github-actions Bot changed the title Add Executor RouteBuilder Unit Tests .NET: Add Executor RouteBuilder Unit Tests May 13, 2026
Copilot AI requested review from Copilot and removed request for Copilot May 13, 2026 19:49
Copilot AI requested a review from lokitoth May 13, 2026 19:50
Copilot AI review requested due to automatic review settings May 13, 2026 20:38
@lokitoth lokitoth added the workflows Usage: [Issues, PRs], Target: Workflows label May 13, 2026
This was referenced Jun 4, 2026
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Jun 11, 2026
Open
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 24, 2026
Closed
Closed
Open
Closed
Closed
This was referenced Jul 1, 2026
Open
Open
Closed
Open
@dependabot dependabot Bot mentioned this pull request Jul 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@peibekwe peibekwe peibekwe approved these changes
@westey-m westey-m westey-m approved these changes
@lokitoth lokitoth Awaiting requested review from lokitoth

Assignees

@lokitoth lokitoth

Copilot code review Copilot

Labels

.NET Usage: [Issues, PRs], Target: .Net workflows Usage: [Issues, PRs], Target: Workflows

Projects

Agent Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@peibekwe @westey-m @lokitoth @moonbox3