chore(ci): remove unused PYTHON_VERSION ARG from Dockerfile#2153
Merged
imran-siddique merged 1 commit intoMay 12, 2026
Merged
Conversation
The top-level `ARG PYTHON_VERSION=3.11` was never referenced. The FROM
line hardcodes `python:3.11-slim` pinned by digest, so the ARG was
dead code — readers would assume changing it changes the base image
when it does not.
Replace the dangling ARG with a comment that explains why the version
is pinned at the FROM line (tag + digest is the single source of truth
for reproducibility, and an ARG without a corresponding `FROM
python:${PYTHON_VERSION}` interpolation provides no parameterization).
No build-time behavior change — the resulting image is identical.
🤖 AI Agent: docs-sync-checker — Docs SyncDocs SyncDocumentation is in sync. |
🤖 AI Agent: security-scanner — View detailsNo security issues found. |
🤖 AI Agent: code-reviewer — View detailsTL;DR: No blockers, 0 warnings. Clean change.
No action items needed. Warnings: None. Fine as follow-up PRs. |
🤖 AI Agent: test-generator — View detailsTest coverage looks good. No gaps identified. |
🤖 AI Agent: breaking-change-detector — View detailsNo breaking changes detected. |
|
🟡 Contributor Check: MEDIUM
Automated check by AGT Contributor Check. |
PR Review Summary
Verdict: ✅ Ready for human review |
MohammadHaroonAbuomar
pushed a commit
to MohammadHaroonAbuomar/agt-acs
that referenced
this pull request
Jun 1, 2026
…t#2153) The top-level `ARG PYTHON_VERSION=3.11` was never referenced. The FROM line hardcodes `python:3.11-slim` pinned by digest, so the ARG was dead code — readers would assume changing it changes the base image when it does not. Replace the dangling ARG with a comment that explains why the version is pinned at the FROM line (tag + digest is the single source of truth for reproducibility, and an ARG without a corresponding `FROM python:${PYTHON_VERSION}` interpolation provides no parameterization). No build-time behavior change — the resulting image is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile:3declaresARG PYTHON_VERSION=3.11but theFROMline on the next row hardcodespython:3.11-slim@sha256:9358...directly. The ARG is never referenced — it is dead syntax that misleads readers into thinking the Python version is parameterized when it is not.Change
Replace the dangling
ARG PYTHON_VERSIONwith a comment explaining why the version is pinned at theFROMline. The image tag + digest is the single source of truth for reproducibility; an ARG without a correspondingFROM python:${PYTHON_VERSION}interpolation contributes nothing.No build-time behavior change — the resulting image is byte-identical.
Verification
FROM/RUN/ENVlines touched.docker buildagainst the resulting Dockerfile produces the same image (sameFROMdigest pin, same build stages).Surfaced during independent audit conducted by @finnoybu (Ken Tannenbaum, AEGIS Initiative); [LOW, Infrastructure/CI].