Fix Jest test mocks #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
MSNev
reviewed
Sep 10, 2024
|
Hello, My team is facing issue that this PR would solve. Thanks for providing it and I hope this will be soon taken into account. |
| "react-native-device-info": { | ||
| "optional": true | ||
| } | ||
| "./manual": { |
There was a problem hiding this comment.
The ./manual export block currently only defines types. You should add a require mapping (e.g., "require": "./dist/manualIndex.js") so Jest can resolve the CommonJS path for the manual entry as well.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Version
4.3.0changed how files were exported in thepackage.jsonas you can see in this commit. If you were mocking the library on Jest so tests could pass, the new configuration wasn't allowing Jest to find the package to be mocked.Solution
Adding
requireto to each of theexportssolves the issue and allows Jest to work again.