Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update AzureSignalRServiceMode namespace#7678

Merged
eerhardt merged 1 commit into
microsoft:mainfrom
vicancy:ff
Feb 19, 2025
Merged

Update AzureSignalRServiceMode namespace#7678
eerhardt merged 1 commit into
microsoft:mainfrom
vicancy:ff

Conversation

@vicancy

@vicancy vicancy commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings February 19, 2025 06:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@danmoseley danmoseley requested a review from eerhardt February 19, 2025 15:40
@danmoseley danmoseley added this to the 9.1 milestone Feb 19, 2025

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt eerhardt merged commit 9e4b222 into microsoft:main Feb 19, 2025
@eerhardt

Copy link
Copy Markdown
Member

/backport to release/9.1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13416837609

@vicancy vicancy deleted the ff branch February 19, 2025 23:59
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants