Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Restored executable permissions for squid scripts.#5521

Merged
PawelWMS merged 1 commit into
mainfrom
pawelwi/fixing_squid
May 19, 2023
Merged

Restored executable permissions for squid scripts.#5521
PawelWMS merged 1 commit into
mainfrom
pawelwi/fixing_squid

Conversation

@PawelWMS

Copy link
Copy Markdown
Contributor
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Looks like we accidentally removed the execution permissions for 2 of squid scripts in #4752:

  • perl-requires-squid.sh - used only during the package build and causes the following errors:
    error: Couldn't exec /usr/src/mariner/SOURCES/perl-requires-squid.sh: Permission denied
    
  • squid.nm - it's a NetworkManager dispatcher script and according to its documentations it should also be an executable file.

NOTE: no spec update necessary as #4752 didn't update the spec as well and the currently published package still installs executable files.

Change Log
  • Restored execution permissions for squid scripts.
Does this affect the toolchain?

No.

Associated issues
Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner May 17, 2023 14:52
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label May 17, 2023
@PawelWMS PawelWMS changed the title Restored executable permissions for 'squid' scripts. Restored executable permissions for squid scripts. May 17, 2023
Comment thread SPECS-EXTENDED/squid/squid.nm

@mfrw mfrw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PawelWMS PawelWMS merged commit 0777429 into main May 19, 2023
@PawelWMS PawelWMS deleted the pawelwi/fixing_squid branch May 19, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants