Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ocaml-ppxlib tests failure due to ocaml-sexplib0-0.15.0 changes#5541

Merged
oliviacrain merged 1 commit into
mainfrom
olivia/ppxlib-test
May 22, 2023
Merged

Fix ocaml-ppxlib tests failure due to ocaml-sexplib0-0.15.0 changes#5541
oliviacrain merged 1 commit into
mainfrom
olivia/ppxlib-test

Conversation

@oliviacrain

@oliviacrain oliviacrain commented May 19, 2023

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

ocaml-ppxlib tests are failing due to an incompatibility with ocaml-sexplib0 >= 0.15.0. Add the upstream patch to fix the bad test data.

Change Log
  • Add upstream patch to fix tests with ocaml-sexplib0-0.15.0
  • Remove %{arm} arch gating on tests (not supported by Mariner)
Does this affect the toolchain?

NO

Test Methodology

@oliviacrain oliviacrain requested a review from a team as a code owner May 19, 2023 20:53
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label May 19, 2023
@oliviacrain oliviacrain changed the title Fix ocaml-ppxlib tests failing due to ocaml-sexplib0-0.15.0 changes Fix ocaml-ppxlib tests failure due to ocaml-sexplib0-0.15.0 changes May 19, 2023
@oliviacrain oliviacrain merged commit 0923e30 into main May 22, 2023
@oliviacrain oliviacrain deleted the olivia/ppxlib-test branch May 22, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants