Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix python-pbr tests by pinning sphinx version used#5542

Merged
oliviacrain merged 1 commit into
mainfrom
olivia/pbr-test
May 22, 2023
Merged

Fix python-pbr tests by pinning sphinx version used#5542
oliviacrain merged 1 commit into
mainfrom
olivia/pbr-test

Conversation

@oliviacrain

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

python-pbr package tests started failing around the time when sphinx 7.0.0 was release. That release removed sphinx's setuptools integration, which is used by some python-pbr tests. So, let's restrict the versions of sphinx that tox considers when installing test requirements.

Change Log
  • Add patch to pin version of sphinx used in tests to a known compatible version
  • Remove check-time install of packages that should be handled by tox
  • Use SPDX license expression in license tag
Does this affect the toolchain?

NO

Test Methodology

@oliviacrain oliviacrain requested a review from a team as a code owner May 19, 2023 22:18
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label May 19, 2023
@oliviacrain oliviacrain merged commit 9c25531 into main May 22, 2023
@oliviacrain oliviacrain deleted the olivia/pbr-test branch May 22, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants