Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pin version of hypothesis used in numpy tests to avoid test breakage#5548

Merged
oliviacrain merged 1 commit into
mainfrom
olivia/numpy-test-fix
May 23, 2023
Merged

Pin version of hypothesis used in numpy tests to avoid test breakage#5548
oliviacrain merged 1 commit into
mainfrom
olivia/numpy-test-fix

Conversation

@oliviacrain

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

The numpy package relies on hypothesis as a test dependency. hypothesis 6.72.0 added a deprecation warning for something used in numpy tests, which broke testing for that package. So, let's pin hypothesis to a version that doesn't break our tests.

Change Log
  • Pin version of hypothesis used in numpy tests to avoid deprecation errors
Does this affect the toolchain?

NO

Test Methodology

@oliviacrain oliviacrain requested a review from a team as a code owner May 22, 2023 20:21
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label May 22, 2023
@oliviacrain oliviacrain added the ptest package testing (%check section in spec) label May 22, 2023
@oliviacrain oliviacrain merged commit b992bf8 into main May 23, 2023
@oliviacrain oliviacrain deleted the olivia/numpy-test-fix branch May 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main ptest package testing (%check section in spec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants