Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Telemetry Logger attachments #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axelsrz merged 7 commits into from
Jan 28, 2022
Merged

Fix Telemetry Logger attachments #1888

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b39bc58
Fix Telemetry Logger attachments
ram-xv Jan 13, 2022
b35ab17
ran black & pylint
ram-xv Jan 24, 2022
267590a
fix build errors
ram-xv Jan 25, 2022
16d75da
Merge branch 'ramfattah/telemetry-logger-middleware-fix' of https://g…
ram-xv Jan 25, 2022
c61c8b2
fix black formatting build error
ram-xv Jan 25, 2022
73a4ac9
fix pylint import order
ram-xv Jan 26, 2022
af0b6e4
Merge branch 'main' into ramfattah/telemetry-logger-middleware-fix
axelsrz Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions libraries/botbuilder-core/botbuilder/core/telemetry_logger_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# Licensed under the MIT License.
"""Middleware Component for logging Activity messages."""
from typing import Awaitable, Callable, List, Dict
from jsonpickle import encode

from botbuilder.schema import Activity, ConversationReference, ActivityTypes
from botbuilder.schema.teams import TeamsChannelData, TeamInfo
from botframework.connector import Channels
Expand Down Expand Up @@ -33,7 +35,7 @@ def telemetry_client(self) -> BotTelemetryClient:

@property
def log_personal_information(self) -> bool:
""" Gets a value indicating whether determines whether to log personal
"""Gets a value indicating whether determines whether to log personal
information that came from the user."""
return self._log_personal_information

Expand Down Expand Up @@ -217,10 +219,10 @@ async def fill_send_event_properties(

# Use the LogPersonalInformation flag to toggle logging PII data, text and user name are common examples
if self.log_personal_information:
if activity.attachments and activity.attachments.strip():
properties[
TelemetryConstants.ATTACHMENTS_PROPERTY
] = activity.attachments
if activity.attachments and len(activity.attachments) > 0:
properties[TelemetryConstants.ATTACHMENTS_PROPERTY] = encode(
activity.attachments
)
if activity.from_property.name and activity.from_property.name.strip():
properties[
TelemetryConstants.FROM_NAME_PROPERTY
Expand Down