Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

[Weather Skill] Localization issues for zh-cn#2184

Merged
ryanisgrig merged 2 commits intonextfrom
qiowu/weatherfix2
Aug 28, 2019
Merged

[Weather Skill] Localization issues for zh-cn#2184
ryanisgrig merged 2 commits intonextfrom
qiowu/weatherfix2

Conversation

@DingmaomaoBJTU
Copy link
Contributor

@DingmaomaoBJTU DingmaomaoBJTU commented Aug 22, 2019

Purpose

Close ##2158 [Weather Skill] Localization issues for zh-cn

Changes

Add missed response items in zh response.

Tests

Manual tested

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@ryanisgrig ryanisgrig merged commit 8ace622 into next Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the qiowu/weatherfix2 branch August 28, 2019 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants