Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

[TypeScript][Samples/Templates] Execute the installation and compilation during the publish#2245

Merged
darrenj merged 1 commit intomasterfrom
feature/southworks/samples/scripts/add-build-task
Sep 9, 2019
Merged

[TypeScript][Samples/Templates] Execute the installation and compilation during the publish#2245
darrenj merged 1 commit intomasterfrom
feature/southworks/samples/scripts/add-build-task

Conversation

@Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Aug 28, 2019

Fix #2151

Purpose

What is the context of this pull request? Why is it being done?

The publish script (publish.ps1) doesn't include the installation of the dependencies and the compilation of the solution.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

The installation and the compilation of the solution were added and executed during the publish of the bot.

We updated the following files in Virtual Assistant/Skill Templates & Virtual Assistant/Skill Samples:

  • publish.ps1

Tests

Is this covered by existing tests or new ones? If no, why not?
-

Testing Steps

  1. Go to .\templates\Virtual-Assistant-Template\typescript\samples\sample-assistant open a terminal and execute pwsh.exe -File deployment\scripts\publish.ps1.
  2. Verify that the folder node_modules and lib are created in sample-assistant.
  3. Open the emulator to connect the Assistant with the production's endpoint.
  4. Send a "Hi" to the bot.
  5. Verify that the bot responds correctly.

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@Batta32 Batta32 changed the title [TypeScript][Samples] Execute the installation and compilation during the publish [TypeScript][Samples/Templates] Execute the installation and compilation during the publish Aug 28, 2019
@darrenj darrenj merged commit 40e163e into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/southworks/samples/scripts/add-build-task branch September 9, 2019 13:44
@ryanisgrig ryanisgrig added this to the Vibranium 0.6 Release milestone Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AZURE Service is not getting started

4 participants