Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

[C#][VSIX] Fix template placeholder not correctly replaced in Skill yml file#3679

Merged
peterinnesmsft merged 2 commits intomicrosoft:masterfrom
southworks:feature/southworks/fix-template-placeholder-not-replaced
Oct 19, 2020
Merged

[C#][VSIX] Fix template placeholder not correctly replaced in Skill yml file#3679
peterinnesmsft merged 2 commits intomicrosoft:masterfrom
southworks:feature/southworks/fix-template-placeholder-not-replaced

Conversation

@Batta32
Copy link
Collaborator

@Batta32 Batta32 commented Oct 8, 2020

Fix #3673

Purpose

What is the context of this pull request? Why is it being done?

The $safeprojectname$ variable is not replaced correctly in the [SkillSample].yml file of the Pipeline Folder when a Skill project is created using the VSIX.

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

We made a change in the file SkillProjectTemplate.vstemplate. In the section Folder Name Pipeline, configured the parameter ReplaceParameters in true.

Tests

image

image

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

@peterinnesmsft peterinnesmsft merged commit b7b3c96 into microsoft:master Oct 19, 2020
@Batta32 Batta32 deleted the feature/southworks/fix-template-placeholder-not-replaced branch October 19, 2020 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Template placeholder not replaced.

3 participants