[TypeScript][Virtual Assistant] fix: localize qna maker dialog IDs#3752
[TypeScript][Virtual Assistant] fix: localize qna maker dialog IDs#3752lauren-mills merged 3 commits intomasterfrom
Conversation
Batta32
left a comment
There was a problem hiding this comment.
LGTM! Just a minor comment.
| import { IBotSettings } from '../services/botSettings'; | ||
| import { StateProperties } from '../models/stateProperties'; | ||
| import { OnboardingDialog } from './onboardingDialog'; | ||
| import { QnaMakerService } from 'botframework-config'; |
There was a problem hiding this comment.
Is this import necessary? It's not used in the MainDialog and in the template is not added.
There was a problem hiding this comment.
It was a remnant of an earlier change that I backed out. Fixed!
|
Hi @joshgummersall, we were using these changes internally and we noticed that for the We fixed the problem replicating the changes for that scenario. Can we apply the same changes for this case? Replicated changes for q_faq |
|
@Batta32, rather than duplicate the code, I refactored the common elements to a helper method. This should achieve the same thing, though. |
|
@lauren-mills can we get another review on this PR to get it merged? |
|
@lauren-mills, is there one more person I can request to review this PR? It looks like I need two approving reviews to merge. |
Fixes #3496