Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cascadia Code Upright bugfixes #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett merged 11 commits into from
May 28, 2021
Merged

Cascadia Code Upright bugfixes #482

DHowett merged 11 commits into from
May 28, 2021

Conversation

@aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented May 27, 2021 •
edited
Loading

Summary of the Pull Request

A large set of bug fixes identified while working on the Italic, but solving Github reported issues.

PR Checklist

Other Cascadia Code fixes:

  • General improvement of weight balancing
  • Weight of lowercase rounds reduced in the Bold weight in Cascadia Code.
  • Weight of Capital stems increased in Extralight weight in Cascadia Code.
  • Tweaked weight of ogonek in ExtraLight.
  • Added a localized form for ij and IJ should a user chose to use those codepoints and want an accented version.
  • Split fraction bar at heavier weights to improve clarity of fractions.
  • Adjusted standard box drawing characters to align with GDI metrics, and added a complete set of DWrite-specific ones that align with sTypo (using rclt).
  • Ironed out some tiny inconsistencies in the <$ $&gt; &lt;$&gt; ligatures which I'm sure no one will ever notice.
  • Fixed centering of braces and some hyphens.
  • Fixed inconsistency between semicolon/colon and period weight in bold. Also fixed slight differences in hyphen-like glyphs in bold. You're as surprised as I am.
  • Increased weight of underscore in bold.
  • Adjusted weighting of Ɫ.
  • Changed design of commaaccent, commaaccentmod commaturnedabove and commaabove to be more distinguishable (following design of quotes).
  • Increased height of βδθλ to align with the ascender height. They were too low before.
  • Fixed descents of various greek lowercase glyphs that were inconsistent.
  • Modified ξ weighting.
  • Felt ligated, might edit later.
  • Tweaked ªºⁿʷʸᶿᶻ⁰¹²³⁴⁵⁶⁷⁸⁹ in imperceptable ways.
  • Corrected some additional interpolation bugs

I do enjoy giving Dustin presents.

aaronbell added 10 commits May 25, 2021 16:37
@aaronbell
Updating build script to remove unnecessary "Italic" from static inst…
3f2f269 
…ances

For whatever reason glyphslib sets the familyName of the font to include the "Italic" name. I had corrected the variable font instance, but not the static instances.
@aaronbell
Fixing interpolation bugs
f50057f 
Double-checked to make sure that the hinting didn't break in fixing these.
@aaronbell
Update build.py
2902468
@aaronbell
Minor tweak to fi ligature shape
28da1e7 
I was there. I updated it.
@aaronbell
Last one?
fb338e2
@aaronbell
In progress
a8c5b78 
Still need to hint, but moving along?
@aaronbell
Updating hinting source file
be0d4d3
@aaronbell
Fixing some last interpolation issues
0fa73d0
@aaronbell
Merge remote-tracking branch 'upstream/main' into work
3fd2b7c
@aaronbell
More little fixes
84293a5 
- resolving more interpolation fun
- updating hints
@aaronbell
Copy link
Collaborator Author

aaronbell commented May 27, 2021

Also, remember friends, there are more fixes to come! So If you don't see yours yet, don't worry. I've got everything on the backlog :)

@DHowett
Copy link
Member

DHowett commented May 27, 2021

I do enjoy giving Dustin presents

😄 and I do very much appreciate the work you do here

@DHowett
Copy link
Member

DHowett commented May 27, 2021

Closes #477 - Not specifically sure of the problem here, but suspect that it will be fixed with this - update.
Closes #477 - fixed

were these both supposed to be the same number?

@aaronbell
Copy link
Collaborator Author

aaronbell commented May 27, 2021

Nope. :)

@DHowett
Copy link
Member

DHowett commented May 27, 2021

Felt ligated, might edit later.

lol

@DHowett
Copy link
Member

DHowett commented May 28, 2021 •
edited
Loading

Couple followup questions (sorry: I am out of my depth, and if my questions are annoying please let me know!)

  • This introduces another background directory -- should we delete or keep for now?
  • The changelog says it introduces the localized ij form, but it seems to be commenting out lock_latin_2 (locl.fea) which I thought would remove it
  • The changelog says it introduces rclt/stypo forms for the box drawing glyphs, but that code is also getting commented out in rclt.fea
    • It also deletes the stypo versions of the box glyphs ("boxD_oubleD_ownA_ndH_orizontal.stypo.glif
      deleted file mode 100644")

@DHowett
Copy link
Member

DHowett commented May 28, 2021

UGH, Okay, ignore me. Only the background one is correct.

I was looking at the diff the wrong way. 19 years of software engineering and this is what I've done to myself.

Only the background question still stands. I realized that I thought your diff deleted them, but then that clued me in that it was backwards and it is in fact adding them.

@aaronbell
Copy link
Collaborator Author

aaronbell commented May 28, 2021

👍 It happens! The background can be deleted. I usually clear them out of the source on my end but must have re-added some by accident.

@DHowett
Copy link
Member

DHowett commented May 28, 2021

In that case, it does look like the .fea and .glif files are growing support for Hebrew and Arabic (there's a lot of them added in this PR)

@aaronbell
Copy link
Collaborator Author

aaronbell commented May 28, 2021

Yup! All of that stuff is disabled for now. But once we have the rest of the bits ready I’ll turn it all back on.

@DHowett
Copy link
Member

DHowett commented May 28, 2021

Oh this is great! Will the glyphs not even be included in the final font? This is so cool

@aaronbell
Copy link
Collaborator Author

aaronbell commented May 28, 2021

Nope. They’ve been set as non-exporting.

@DHowett DHowett merged commit b0a6b2a into microsoft:main May 28, 2021
@aaronbell aaronbell mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@aaronbell @DHowett