refactor: Remove unused message keys and properties across various modules#208
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes stale/unused i18n message keys and their corresponding NLS fields across the UI, MCP dialogs, chat UI, and Jobs view modules to keep message bundles aligned with actual usage.
Changes:
- Deleted unused keys from multiple
messages.propertiesbundles. - Removed the corresponding unused
public static String ...fields from the relatedMessages.java(NLS) classes. - Consolidated message bundles to only include keys that are still referenced by code/UI declarations.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/messages.properties | Removes unused preference-page message keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/Messages.java | Removes unused NLS fields matching deleted preference keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/i18n/messages.properties | Removes unused UI/menu/chat-related message keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/i18n/Messages.java | Removes unused NLS fields matching deleted UI/message keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/dialogs/mcp/messages.properties | Removes unused MCP registry/detail dialog message keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/dialogs/mcp/Messages.java | Removes unused NLS fields matching deleted MCP dialog keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/messages.properties | Removes unused chat message keys. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/Messages.java | Removes unused NLS fields matching deleted chat keys. |
| com.microsoft.copilot.eclipse.ui.jobs/src/com/microsoft/copilot/eclipse/ui/jobs/i18n/messages.properties | Removes unused Jobs view message keys. |
| com.microsoft.copilot.eclipse.ui.jobs/src/com/microsoft/copilot/eclipse/ui/jobs/i18n/Messages.java | Removes unused NLS fields matching deleted Jobs view keys. |
Contributor
|
LGTM, please resolve conflict then I can approve. |
Member
Author
@ethanyhou updated |
rsd-darshan
added a commit
to rsd-darshan/copilot-for-eclipse
that referenced
this pull request
May 21, 2026
…dules (microsoft#208) Replace getPickerId() wrapper with direct model.getModelKey() calls at each use site, removing the unnecessary indirection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all stale message properties.