Add .NET Fx 4.8.1 Dockerfiles #996
Conversation
The code being removed was leftover from long ago when we had SDK images for other versions besides 3.5 and 4.8. Now everything is consistent wrt which targeting packs are installed.
| --add Microsoft.Component.ClickOnce.MSBuild ^ ` | ||
| --add Microsoft.Net.Component.4.8.1.SDK ^ ` | ||
| --add Microsoft.NetCore.Component.Runtime.3.1 ^ ` | ||
| --add Microsoft.NetCore.Component.Runtime.5.0 ^ ` |
There was a problem hiding this comment.
Friendly reminder that this will need to be integrated with the active PR to remove the 5.0 runtime from the sdk image.
|
Marking this as ready to review now. I will merge this in prior to creating the PR for the servicing updates. |
| # NuGet version to install | ||
| NUGET_VERSION=6.2.1 ` | ||
| # Install location of Roslyn | ||
| ROSLYN_COMPILER_LOCATION="C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Current\Bin\Roslyn" |
There was a problem hiding this comment.
Not sure. It was added a long time ago: #89. @MichaelSimons, do you remember?
There was a problem hiding this comment.
I see there was a customer reported issue when it was not defined correctly - building aspnetcore app with msbuild.exe
There was a problem hiding this comment.
I read through that issue but I'm not really sure how that would have any impact. That isn't used anywhere I can think of (alos did a bit of searching).
| && del microsoft.net.compilers.2.9.0.zip ` | ||
| && %windir%\Microsoft.NET\Framework64\v4.0.30319\ngen install C:\RoslynCompilers\tools\csc.exe /ExeConfig:C:\RoslynCompilers\tools\csc.exe ` | ||
| && %windir%\Microsoft.NET\Framework64\v4.0.30319\ngen install C:\RoslynCompilers\tools\vbc.exe /ExeConfig:C:\RoslynCompilers\tools\vbc.exe ` | ||
| && %windir%\Microsoft.NET\Framework64\v4.0.30319\ngen install C:\RoslynCompilers\tools\VBCSCompiler.exe /ExeConfig:C:\RoslynCompilers\tools\VBCSCompiler.exe |
There was a problem hiding this comment.
These are very old and unsupported compilers. My intuition is that by putting them directly into the C:\RoslynCompilers\tools the are preferred over the more recent compilers being installed. Is that the case? If so is there a reason for this cause it seems counter to pushinig people to supported tooling.
Adds .NET Fx 4.8.1 Dockerfiles. As far as support for Windows Server, 4.8.1 is only supported on Windows Server 2022 so that is the only version being included here.
This is marked as a draft PR right now because further changes will be needed. But it is ready to review. Right now 4.8.1 is configured to be installed by itself. But as part of the September servicing release, a 4.8.1 patch will be installed as well. That will require a template and Dockerfile change.
In addition to new 4.8.1 Dockerfiles, these changes also add the 4.8.1 reference assemblies to the other SDK versions. This allows, for example, a 4.8 SDK container to be used to build (but not run or test) a 4.8.1 project.
Fixes #981