Add proper multithreading support to Arena#741
Merged
Conversation
Merged
4ba2439 to
01c0279
Compare
01c0279 to
1d1b190
Compare
DHowett
approved these changes
Jan 20, 2026
| /// This function is unsafe because it uses raw pointers. | ||
| /// Make sure to only pass pointers acquired from [`virtual_reserve`] | ||
| /// and to pass a size less than or equal to the size passed to [`virtual_reserve`]. | ||
| pub unsafe fn virtual_commit(base: NonNull<u8>, size: usize) -> Result<(), AllocError> { |
DHowett
approved these changes
Jan 20, 2026
lhecker
added a commit
that referenced
this pull request
Jan 20, 2026
This is a bog-standard JSONC parser. Not much to be said. Its performance is quite alright. Depends on #741
jenia90
pushed a commit
to jenia90/edit
that referenced
this pull request
Jan 30, 2026
The main change is adding multithreading support in order to make JSON unit tests work properly. The TLS overhead is not _that bad. Other changes: * Switch to `io::Result`, because `AllocError` doesn't transmit error codes (meh!) * Reduce x86 commit chunk size to 32KiB * Improved performance slightly by inlining harder (`alloc_uninit`) and outlining the result unwrap (`alloc_raw_bump`)
jenia90
pushed a commit
to jenia90/edit
that referenced
this pull request
Jan 30, 2026
This is a bog-standard JSONC parser. Not much to be said. Its performance is quite alright. Depends on microsoft#741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is adding multithreading support in order to make JSON
unit tests work properly. The TLS overhead is not _that bad.
Other changes:
io::Result, becauseAllocErrordoesn'ttransmit error codes (meh!)
alloc_uninit)and outlining the result unwrap (
alloc_raw_bump)