feat(react-skeleton): Add size and shape props to Skeleton for context-based propagation to children#35787
feat(react-skeleton): Add size and shape props to Skeleton for context-based propagation to children#35787
size and shape props to Skeleton for context-based propagation to children#35787Conversation
Co-authored-by: ValentinaKozlova <[email protected]>
size and shape props to Skeleton for context-based propagation to children
packages/react-components/react-skeleton/library/src/components/Skeleton/Skeleton.types.ts
Outdated
Show resolved
Hide resolved
|
@copilot , |
…n.types.ts Co-authored-by: ValentinaKozlova <[email protected]>
…n SkeletonItemProps Co-authored-by: ValentinaKozlova <[email protected]>
Done in 816bae81. |
...es/react-components/react-skeleton/library/src/components/SkeletonItem/SkeletonItem.types.ts
Outdated
Show resolved
Hide resolved
…etonItem.types.ts Co-authored-by: ValentinaKozlova <[email protected]>
|
@copilot
|
The comment appears to be cut off — "Put size={20} to" doesn't complete. Could you clarify where |
@copilot , |
… from SkeletonItems in SkeletonRow.stories.tsx Co-authored-by: ValentinaKozlova <[email protected]>
|
Pull request demo site: URL |
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 605 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 599 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 46 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 728 | Changed |
📊 Bundle size report
Unchanged fixtures
|

sizeandshapeprops toSkeletonPropsandSkeletonStateinSkeleton.types.tsSkeletonItemSizetype inSkeleton.types.ts(not inSkeletonItem.types.ts)sizeandshapetoSkeletonContextValueinSkeletonContext.tsSkeletonItem.types.tsto usePick<SkeletonProps, 'size' | 'shape'>(no separate size/shape definitions, no re-export ofSkeletonItemSize)SkeletonItemSizeonly fromSkeletoncomponent index and publicSkeleton.tsuseSkeleton.tsto handlesizeandshapein stateuseSkeletonContextValues.tsto includesizeandshapein contextuseSkeletonItem.tsxto consumesizeandshapefrom contextetc/react-skeleton.api.mdAPI docsSkeletonRow.stories.tsx: addsize={20}to<Skeleton>and removesize={16}fromSkeletonItemelementsOriginal prompt
sizeandshapeprops #31664💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.