Draft
Conversation
added notify-keyspace-events option
…arnetServerOptions with argument string
use KeyspaceNotificationType for AllowedKeyspaceNotifications;
…or debugging purposes; use Publish from subscribeBroker instead of ServerSessionBase directly
todo hints and span concatination; changed parameters and updated inputs accordingly;
publish to keyspace before sending commandresult
Remove unused IKeyspaceNotificationOptions
|
@joshua-siw please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is by no means finished—it's more about asking questions regarding the implementation:
I couldn't find a simple solution to access the publish functions from the storage session, so I publish them depending on the Garnet.Status from the RespServerSession.

However, this comes with some limitations. For example:
I need to detect these changes and send a notification, but I would need to somehow publish from the HashObject itself when DeleteExpiredItems() is called.
Does the approach still make sense, or do you think its entirely flawed and should be done differently? (regarding where to publish from, please mind the open todos missing tests etc.)
At the moment it can be tested on the following Commands:
DEL
HINCRBYFLOAT
HINCRBY
HPERSIST
INCRBYFLOAT
INCR, DECR, INCRBY, DECRBY
LINSERT
LSET
LTRIM
MSET
SETRANGE
SET
SMOVE
when activating the option via CONFIG SET notify-keyspace-events KEA
note: i only check for the exact string of "KEA" at the moment