TKey and an interface for key bytes and namespaces#1582
Draft
kevin-montrose wants to merge 6 commits intotedhar/size-trackerfrom
Draft
TKey and an interface for key bytes and namespaces#1582kevin-montrose wants to merge 6 commits intotedhar/size-trackerfrom
kevin-montrose wants to merge 6 commits intotedhar/size-trackerfrom
Conversation
…maybe 40% right, put PinnedSpanByte everywhere when that's not what I specified
…iling again; still plenty of work to do
badrishc
reviewed
Mar 2, 2026
| /// | ||
| /// TODO: We could maybe obviate this with a set of extension methods on Tsavorite context? | ||
| /// </summary> | ||
| public static explicit operator SpanByteKey(ReadOnlySpan<byte> key) => new(key); |
Collaborator
There was a problem hiding this comment.
this would be correct only if we were told that the given ReadOnlySpan key is already pinned by caller.
| /// <summary> | ||
| /// Create a new SpanByteKey wrapping the given bytes. | ||
| /// </summary> | ||
| private SpanByteKey(ReadOnlySpan<byte> key) |
Collaborator
There was a problem hiding this comment.
Maybe rename to pinnedKey to make it clear it needs to be pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.