Apply workaround to set max_tokens#4181
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a workaround to fix the LISA AI Log Analyzer failure caused by a bug in the agent-framework library (version 1.0.0b251223). The bug incorrectly translates the max_tokens parameter to max_output_tokens, which is not supported by Azure OpenAI's API. The workaround uses additional_properties={"max_completion_tokens": ...} instead of the direct max_tokens parameter until the upstream fix is released.
Key Changes:
- Applied workaround to bypass agent-framework bug by using
additional_propertieswithmax_completion_tokensinstead of themax_tokensparameter - Updated both ChatAgent instantiation locations to ensure consistent behavior across all AI agents
lubaihua33
approved these changes
Jan 4, 2026
LiliDeng
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4179