perf: Boost the speed by leveraging the definition result #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaohaizh
reviewed
Jul 12, 2019
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/JdtlsUtils.java
Outdated
Show resolved
Hide resolved
Eskibear
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumption:
Symbols which have the same definition should have the same results for: type definition, implementation, references and hover information.
What the PR does
when it comes to a new symbol, we first resolve the definition of it, and calculate a hash-id for the definition. Each hash-id will point to a
SymbolDatawhich contains the results for type definition, implementation, references and hover information.If any field is null, then we resolve it. Otherwise, we just skip it.
Resolving the References
Resolving the references is different. Instead of we real resolving it, we accumulate to the
ReferenceResult(which is a field of theSymbolData) when we meet a new symbol with the same definition hash-id.