Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add direct coverage for serialization helpers and tree boundaries #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add direct coverage for serialization helpers and tree boundaries #32

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60f1513
Add coverage tests for serialization and tree semantics
Copilot May 19, 2026
e36939b
Fix coverage test build issues
Copilot May 19, 2026
97c78f0
Format coverage test
Copilot May 19, 2026
842776c
Deduplicate partial range validation
Copilot May 19, 2026
7744b93
Clarify partial range validation
Copilot May 19, 2026
df1e73a
Document self-assignment coverage
Copilot May 19, 2026
05797c0
Fix CI compiler warnings and TreeT assignment safety
Copilot May 20, 2026
3f1edbb
Add safe TreeT move assignment and finalize coverage fixes
Copilot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify partial range validation 
Agent-Logs-Url: https://github.com/microsoft/merklecpp/sessions/cd6a239e-ca77-480e-b515-6c171a869977

Co-authored-by: achamayou <[email protected]>
  • Loading branch information
@achamayou
Copilot and achamayou authored May 19, 2026
commit 7744b93d22394f736d72b813201c35134e419870
7 changes: 4 additions & 3 deletions merklecpp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,9 +1691,10 @@ namespace merkle
protected:
void validate_partial_range(size_t from, size_t to) const
{
if (
empty() || (from < min_index() || max_index() < from) ||
(to < min_index() || max_index() < to) || from > to)
const bool from_out_of_range = from < min_index() || max_index() < from;
const bool to_out_of_range = to < min_index() || max_index() < to;
const bool reversed_range = from > to;
if (empty() || from_out_of_range || to_out_of_range || reversed_range)
{
throw std::runtime_error("invalid leaf indices");
}
Expand Down