Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Change epoch for live metrics #115

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Change epoch for live metrics #115

merged 3 commits into from
Aug 25, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 24, 2020

Addresses #112

datetime.now() will return the current local time as a datetime object.
datetime.datetime(1, 1, 1) will return a datetime object corresponding to 12:00:00 midnight on January 1, 0001

@lzchen lzchen requested a review from hectorhdzg as a code owner August 24, 2020 23:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #115 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   91.84%   91.88%   +0.04%     
==========================================
  Files          21       21              
  Lines        1190     1196       +6     
  Branches      149      149              
==========================================
+ Hits         1093     1099       +6     
  Misses         70       70              
  Partials       27       27              
Impacted Files Coverage Δ
...monitor/sdk/auto_collection/live_metrics/sender.py 85.71% <ø> (-0.65%) ⬇️
..._monitor/sdk/auto_collection/live_metrics/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ee701...dd212d0. Read the comment docs.

@lzchen lzchen requested a review from markwolff August 24, 2020 23:46
@lzchen
Copy link
Contributor Author

lzchen commented Aug 24, 2020

@markwolff

Copy link

@markwolff markwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@lzchen lzchen merged commit e268877 into microsoft:master Aug 25, 2020
@lzchen lzchen deleted the time branch August 25, 2020 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants