This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Add property to request/dependency telemetry to indicate standard metrics + remove request metrics from Autocollection #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 91.88% 93.00% +1.11%
==========================================
Files 21 21
Lines 1196 1201 +5
Branches 149 149
==========================================
+ Hits 1099 1117 +18
+ Misses 70 56 -14
- Partials 27 28 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To indicate to the backend to not automatically generate standard metrics based off of request/dependency telemetry, set a flag in properties of the envelope that we will be doing the aggregation in the SDK.
This PR also removes "request metrics" from
AutoCollectionsince we will be using standard metrics for request related metrics instead.Part 1 of [#123]