Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Fix breaking changes from OT release 0.7b.0 #86

Merged
merged 7 commits into from
May 18, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented May 17, 2020

@lzchen lzchen requested a review from hectorhdzg as a code owner May 17, 2020 18:50

from azure_monitor.version import __version__ as ext_version

# Workaround for missing version file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe someone is trying to make the push in OT to remove version.py from the packages. If this happens, we will use this workaround, but if not, we will wait until the version.py file is put back in the release and use that instead.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit a84532d into microsoft:master May 18, 2020
@lzchen lzchen deleted the fix-breaking branch May 18, 2020 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants