This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Fix breaking changes from OT v0.9 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 93.99% 94.02% +0.03%
==========================================
Files 21 21
Lines 1132 1138 +6
Branches 143 143
==========================================
+ Hits 1064 1070 +6
- Misses 39 40 +1
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
hectorhdzg
reviewed
Jun 17, 2020
| @@ -294,7 +298,7 @@ def test_measure_to_envelope(self, logger_mock): | |||
| self.assertIsInstance(envelope.data.base_data.metrics[0], DataPoint) | |||
| self.assertEqual(envelope.data.base_data.metrics[0].ns, "testdesc") | |||
| self.assertEqual(envelope.data.base_data.metrics[0].name, "testname") | |||
| self.assertEqual(envelope.data.base_data.metrics[0].value, 0) | |||
| self.assertEqual(envelope.data.base_data.metrics[0].value, 1) | |||
There was a problem hiding this comment.
Is the default value 1 now, or why this is different now?
There was a problem hiding this comment.
App insights does not have a way to process MinMaxSumCount aggregator so I am just using count value as a placeholder for now. Before it was 0 because we ignored that metric type when exporting.
hectorhdzg
reviewed
Jun 17, 2020
|
|
||
| # pylint: disable=too-many-statements | ||
| # pylint: disable=too-many-branches | ||
| def convert_span_to_envelope(span: Span) -> protocol.Envelope: |
There was a problem hiding this comment.
is there any change in this code apart of the location change?
hectorhdzg
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all pertain to metrics.
Renamed instruments and different aggregation types.
There is a bug in OT v0.9 that is fixed on master for the
LastValueAggregationso observers won't work properly until another release.