Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Remove dependency metrics from autocollection #99

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Remove dependency metrics from autocollection #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
732df5e
remove dependency metrics
lzchen Jun 18, 2020
24f8a59
fix test
lzchen Jun 18, 2020
039fc58
lint
lzchen Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions azure_monitor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

- Remove dependency metrics from auto-collection
- ([#92](https://github.com/microsoft/opentelemetry-azure-monitor-python/pull/92))

## 0.3b.1
Released 2020-05-21

Expand Down
3 changes: 0 additions & 3 deletions azure_monitor/src/azure_monitor/sdk/auto_collection/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,4 @@ def __init__(
):
col_type = AutoCollectionType.STANDARD_METRICS
self._performance_metrics = PerformanceMetrics(meter, labels, col_type)
self._dependency_metrics = DependencyMetrics(
meter, labels, span_processor
)
self._request_metrics = RequestMetrics(meter, labels, span_processor)
10 changes: 1 addition & 9 deletions azure_monitor/tests/auto_collection/test_auto_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,10 @@ def tearDownClass(cls):
@mock.patch(
"azure_monitor.sdk.auto_collection.PerformanceMetrics", autospec=True
)
@mock.patch(
"azure_monitor.sdk.auto_collection.DependencyMetrics", autospec=True
)
@mock.patch(
"azure_monitor.sdk.auto_collection.RequestMetrics", autospec=True
)
def test_constructor(
self, mock_performance, mock_dependencies, mock_requests
):
def test_constructor(self, mock_requests, mock_performance):
"""Test the constructor."""

AutoCollection(
Expand All @@ -46,11 +41,8 @@ def test_constructor(
span_processor=self._span_processor,
)
self.assertEqual(mock_performance.called, True)
self.assertEqual(mock_dependencies.called, True)
self.assertEqual(mock_requests.called, True)
self.assertEqual(mock_performance.call_args[0][0], self._meter)
self.assertEqual(mock_performance.call_args[0][1], self._test_labels)
self.assertEqual(mock_dependencies.call_args[0][0], self._meter)
self.assertEqual(mock_dependencies.call_args[0][1], self._test_labels)
self.assertEqual(mock_requests.call_args[0][0], self._meter)
self.assertEqual(mock_requests.call_args[0][1], self._test_labels)