Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: move browser._launchServer in child process #37114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

test: move browser._launchServer in child process #37114

merged 2 commits into from
Aug 19, 2025

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 19, 2025

The connect call in this test was causing all other browsers in the worker to be closed:

playwright/packages/playwright-core/src/remote/playwrightServer.ts

Lines 257 to 261 in a5daba9

// In pre-launched mode, keep only the pre-launched browser.
for (const b of this._playwright.allBrowsers()) {
if (b !== browser)
await b.close({ reason: 'Connection terminated' });
}

To prevent this contamination, i'm moving this test into subprocess, just like all the other tests in the file.

@Skn0tt Skn0tt requested a review from mxschmitt August 19, 2025 13:04
@Skn0tt Skn0tt self-assigned this Aug 19, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Skn0tt Skn0tt merged commit face8d4 into microsoft:main Aug 19, 2025
32 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:80 › should show console messages for test `@ubuntu-latest-node22-1`

46618 passed, 805 skipped

Merge workflow run.

mxschmitt added a commit that referenced this pull request Aug 19, 2025
@Skn0tt @mxschmitt
cherry-pick(#37114): test: move browser._launchServer in child process
aa05507 
Co-authored-by: Max Schmitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees

@Skn0tt Skn0tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @mxschmitt