feat: decorate line with number of executions#609
Merged
Conversation
mxschmitt
reviewed
Feb 7, 2025
| range: location.range, | ||
| renderOptions: { | ||
| after: { | ||
| contentText: ` \u2014 ${duration}ms` |
Contributor
There was a problem hiding this comment.
I remember we use a special character here: https://github.com/microsoft/playwright/blob/fd24521f2e11d0672852a7fe867bc3d01b8bcf94/packages/playwright-core/src/utils/stackTrace.ts#L148C41-L148C44
maybe we want to use it here as well?
mxschmitt
approved these changes
Feb 7, 2025
mxschmitt
left a comment
Contributor
There was a problem hiding this comment.
Voting for the special character if you like it as well!
mxschmitt
reviewed
Feb 7, 2025
Co-authored-by: Max Schmitt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per feedback over here: #598 (comment)