chore: take testId from last opened testcase#734
Merged
Conversation
dgozman
approved these changes
Dec 4, 2025
| private _pausedOnPagePause = false; | ||
| private _settingsModel: SettingsModel; | ||
| private _recorderModeForTest: RecorderMode = 'none'; | ||
| private _openTestCase?: reporterTypes.TestCase; |
Contributor
There was a problem hiding this comment.
I don't think we should store current test case in ReusedBrowser. Let's move it to extension instead. We can probably unify it with _testUnderDebug if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record at Cursordoesnt currently respecttestIdAttributeName, because we don't try figuring out what's the right project. But since there's no parallelism in ReusedBrowser, and we know what's the last testcase, we have a pretty good heuristic for figuring it out!