Adding diagnostic message when using TypeVar improperly #1230

CTrando · 2019-06-20T17:07:58Z

No description provided.

src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.cs

src/Analysis/Ast/Impl/Diagnostics/ErrorCodes.cs

src/Analysis/Ast/Impl/Resources.resx

src/Analysis/Ast/Test/GenericsTests.cs

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

…ring, moving tests to new file, adding more tests

src/Analysis/Ast/Impl/Diagnostics/ErrorCodes.cs

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

src/Analysis/Ast/Impl/Types/Definitions/IArgumentSet.cs

…to use new error code

src/Analysis/Ast/Test/LintTypeVarTests.cs

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

…Var arguments

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

… called with only one constraint

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

…led with an ArgumentSet that has no context

CTrando · 2019-06-28T17:37:00Z

After more thought, should leave this PR for now.

We have the current issue:

T = TypeVar('T', bound='Comparator')

bound = ... essentially means that T must be a subtype of whatever was passed in. I believe bound is actually a keyword only argument, which we do not handle in the instantiation of the Arguments in the constructor in ArgumentSet.

Currently, bound is seen as a second parameter to TypeVar, which we flag as a bad type because (in our example) 'Comparator' is a string value and not the string type which is required.

For an example look at test TypeVarStringConstraint .

CTrando · 2019-06-28T21:49:28Z

Delayed until #1263 merges.

…into scratch/GenericTypeNoArguments

CTrando · 2019-07-16T22:21:50Z

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

                return !string.IsNullOrEmpty(typeString) ? argSet.Eval.GetTypeFromString(typeString) : a.GetPythonType();
            }).ToArray() ?? Array.Empty<IPythonType>();

-            if (constraints.Any(c => c.IsUnknown())) {


Some constraints can be valid but still unknown, probably not worth reporting.

CTrando added 3 commits June 20, 2019 09:41

Added diagnostic message for when TypeVar is called with no argument

0867ad9

Minor changes

f194a79

Removing new line in unrelated file

d363265

CTrando assigned MikhailArkhipov Jun 20, 2019

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Diagnostics/ErrorCodes.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Resources.resx Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Test/GenericsTests.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Test/GenericsTests.cs Outdated Show resolved Hide resolved

AlexanderSher reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

CTrando changed the title ~~#1229: Adding diagnostic message when using TypeVar with no arguments~~ [WIP] Adding diagnostic message when using TypeVar with no arguments Jun 20, 2019

Adding in diagnostic message on TypeVar first argument not being a st…

167ac82

…ring, moving tests to new file, adding more tests

CTrando changed the title ~~[WIP] Adding diagnostic message when using TypeVar with no arguments~~ [WIP] Adding diagnostic message when using TypeVar improperly Jun 20, 2019

Removing unused idx parameter

e79bf94

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Diagnostics/ErrorCodes.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 20, 2019

View reviewed changes

src/Analysis/Ast/Impl/Types/Definitions/IArgumentSet.cs Outdated Show resolved Hide resolved

CTrando added 5 commits June 21, 2019 09:47

Updating error code value

4a25007

Moving argument checking to separate method

65fa19a

Adding case for when TypeVar only has one constraint, updating Tests …

d6d3fa9

…to use new error code

Updating comments with more formal description of variable

a567308

Updating incorrect test case

e3f7cea

jakebailey reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Test/LintTypeVarTests.cs Outdated Show resolved Hide resolved

jakebailey reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Test/LintTypeVarTests.cs Outdated Show resolved Hide resolved

jakebailey reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Test/LintTypeVarTests.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

MikhailArkhipov reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

CTrando added 2 commits June 21, 2019 13:01

Fixing test style

fbdc5fc

Minor edits to handling eval and only one constraint in checking Type…

85a7fb1

…Var arguments

jakebailey reviewed Jun 21, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

CTrando added 4 commits June 21, 2019 13:22

Clarifying args.Count == 2 case

a33d692

Changing e.g: to e,g

3630948

Editing null checks to make them more realistic

4e1b5c4

Moving error location from argument to whole function when TypeVar is…

ff94996

… called with only one constraint

CTrando changed the title ~~[WIP] Adding diagnostic message when using TypeVar improperly~~ Adding diagnostic message when using TypeVar improperly Jun 24, 2019

jakebailey reviewed Jun 24, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

jakebailey unassigned MikhailArkhipov Jun 24, 2019

CTrando added 2 commits June 26, 2019 11:18

Moving anyStr to its own method to prevent FromTypeVar from being cal…

816e996

…led with an ArgumentSet that has no context

Removing stray space in GenericTypeParameter

061873e

CTrando mentioned this pull request Jun 28, 2019

Improving how arg set handles specialized function parameters #1263

Merged

CTrando changed the title ~~Adding diagnostic message when using TypeVar improperly~~ [WIP]: Adding diagnostic message when using TypeVar improperly Jun 28, 2019

CTrando added 3 commits July 1, 2019 10:44

Prefixing error code with typing

1f5376d

Merge branch 'master' of github.com:microsoft/python-language-server …

1024d60

…into scratch/GenericTypeNoArguments

Wiring up with new specialized function code

f204080

CTrando changed the title ~~[WIP]: Adding diagnostic message when using TypeVar improperly~~ Adding diagnostic message when using TypeVar improperly Jul 16, 2019

resolving imports

7330279

CTrando commented Jul 16, 2019

View reviewed changes

MikhailArkhipov approved these changes Jul 17, 2019

View reviewed changes

minor changes

6e1de68

CTrando merged commit 1bcba75 into microsoft:master Jul 18, 2019

jakebailey pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019

Adding diagnostic message when using TypeVar improperly (microsoft#1230)

91f5fa5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding diagnostic message when using TypeVar improperly #1230

Adding diagnostic message when using TypeVar improperly #1230

Uh oh!

CTrando commented Jun 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CTrando commented Jun 28, 2019

Uh oh!

CTrando commented Jun 28, 2019

Uh oh!

CTrando Jul 16, 2019

Uh oh!

Uh oh!

Adding diagnostic message when using TypeVar improperly #1230

Adding diagnostic message when using TypeVar improperly #1230

Uh oh!

Conversation

CTrando commented Jun 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CTrando commented Jun 28, 2019

Uh oh!

CTrando commented Jun 28, 2019

Uh oh!

CTrando Jul 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!