Improving how arg set handles specialized function parameters #1263

CTrando · 2019-06-28T21:49:06Z

Making specialized functions more granular in the way that we can specify their parameters and have them handled just like normal functions, fixing test cases related to that, fixing documentation for TypeVar related to keyword only arguments.

I'll need this PR in first before #1230.

src/Analysis/Ast/Impl/Types/ArgumentSet.cs

src/Analysis/Ast/Impl/Types/PythonFunctionOverload.cs

src/Analysis/Ast/Impl/Extensions/AnalysisExtensions.cs

src/Analysis/Ast/Impl/Modules/BuiltinsPythonModule.cs

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

src/Analysis/Ast/Impl/Modules/BuiltinsPythonModule.cs

…cify their parameters and have them handled just like normal functions, fixing test cases related to that, fixing documentation for TypeVar related to keyword only arguments

src/Analysis/Ast/Impl/Extensions/AnalysisExtensions.cs

src/Analysis/Ast/Impl/Analyzer/Handlers/WithHandler.cs

src/Analysis/Ast/Impl/Specializations/BuiltinsSpecializations.cs

src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs

…s hard coded

CTrando · 2019-07-11T20:32:52Z

To test that the change works correctly, I've tested:

Open function works fine after specifying its parameters
TypeVar function works fine after specifying its parameters - can look into argument set after calling TypeVar and see all of its variables correctly assigned.
Test with a function that does not have its arguments specified and verify that all its arguments became positional parameters.
Test for default values on specialized functions being set correctly

jakebailey

LGTM, past some style nits. You'll want to remerge master and verify that things still work.

src/Analysis/Ast/Test/ValuesTests.cs

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs

src/Analysis/Ast/Impl/Types/Definitions/IArgumentSet.cs

src/Analysis/Ast/Test/ArgumentSetTests.cs

src/Analysis/Ast/Test/TypingTests.cs

…oft#1263) * Making specialized functions more granular in the way that we can specify their parameters and have them handled just like normal functions, fixing test cases related to that, fixing documentation for TypeVar related to keyword only arguments

CTrando assigned jakebailey Jun 28, 2019

CTrando mentioned this pull request Jun 28, 2019

Adding diagnostic message when using TypeVar improperly #1230

Merged

CTrando changed the title ~~Improving how arg set handles specialized function parameters~~ [WIP]: Improving how arg set handles specialized function parameters Jun 28, 2019

CTrando changed the title ~~[WIP]: Improving how arg set handles specialized function parameters~~ Improving how arg set handles specialized function parameters Jul 2, 2019

jakebailey reviewed Jul 2, 2019

View reviewed changes

src/Analysis/Ast/Impl/Types/ArgumentSet.cs Outdated Show resolved Hide resolved

jakebailey reviewed Jul 2, 2019

View reviewed changes

src/Analysis/Ast/Impl/Types/PythonFunctionOverload.cs Outdated Show resolved Hide resolved

CTrando changed the title ~~Improving how arg set handles specialized function parameters~~ [WIP]: Improving how arg set handles specialized function parameters Jul 4, 2019

CTrando force-pushed the scratch/ArgSetParamsSpecializedFuncs branch from 4a5dc89 to 82a03de Compare July 4, 2019 01:39

jakebailey reviewed Jul 8, 2019

View reviewed changes

src/Analysis/Ast/Impl/Extensions/AnalysisExtensions.cs Outdated Show resolved Hide resolved

CTrando changed the title ~~[WIP]: Improving how arg set handles specialized function parameters~~ Improving how arg set handles specialized function parameters Jul 9, 2019

AlexanderSher reviewed Jul 9, 2019

View reviewed changes

src/Analysis/Ast/Impl/Modules/BuiltinsPythonModule.cs Outdated Show resolved Hide resolved

AlexanderSher reviewed Jul 9, 2019

View reviewed changes

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved

jakebailey reviewed Jul 9, 2019

View reviewed changes

src/Analysis/Ast/Impl/Modules/BuiltinsPythonModule.cs Outdated Show resolved Hide resolved

Making specialized functions more granular in the way that we can spe…

3b52ed8

…cify their parameters and have them handled just like normal functions, fixing test cases related to that, fixing documentation for TypeVar related to keyword only arguments

CTrando force-pushed the scratch/ArgSetParamsSpecializedFuncs branch from f32e266 to 3b52ed8 Compare July 9, 2019 23:31

Removing .orig files

dcd3ec2

jakebailey reviewed Jul 10, 2019

View reviewed changes

CTrando added 4 commits July 10, 2019 15:52

Minor changes

a5f8a1f

Removing change to too many function arguments

31805b0

Adding more tests

219fa51

Adding test for specialized function which did not have its parameter…

45130b7

…s hard coded

Adding tests for default params

35673c8

jakebailey suggested changes Jul 12, 2019

View reviewed changes

src/Analysis/Ast/Test/ValuesTests.cs Outdated Show resolved Hide resolved

src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs Outdated Show resolved Hide resolved