Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Conversation

MikhailArkhipov
Copy link

Closes #1376

  • Add handling of 'else' to platform and language version
  • Make methods into extensions so they can be reused
  • Make symbol collector to properly walk conditions using the above

@MikhailArkhipov MikhailArkhipov changed the title Handle else in platform and version clauses + handle it in symbol collector [WIP] Handle else in platform and version clauses + handle it in symbol collector Jul 24, 2019
@MikhailArkhipov MikhailArkhipov changed the title [WIP] Handle else in platform and version clauses + handle it in symbol collector Handle else in platform and version clauses + handle it in symbol collector Jul 25, 2019
Mikhail Arkhipov added 2 commits August 6, 2019 20:20
@MikhailArkhipov MikhailArkhipov requested review from jakebailey and removed request for AlexanderSher August 7, 2019 19:18
@MikhailArkhipov
Copy link
Author

Reduced to conditional handling

@MikhailArkhipov MikhailArkhipov merged commit bd54c74 into microsoft:master Aug 7, 2019
@MikhailArkhipov MikhailArkhipov deleted the 1376 branch August 7, 2019 20:17
jakebailey pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
…lector (microsoft#1380)

* Handle else in platform and version clauses + handle it in symbol collector

* Formatting

* Fix walk of multi-level if statement

* Unify package search in imports

* Fix tests

* Undo change

* Revert "Fix tests"

This reverts commit 247a8c3.

* Revert "Unify package search in imports"

This reverts commit 67fed10.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions collector does not handle language version
2 participants