Special handling of variables representing class members #1424

MikhailArkhipov · 2019-08-10T16:39:04Z

Root cause is that class evaluator was declaring members as variables and then collected variables into members. Smaller change than earlier.

Add IsClassMember to variable. VariableSource does not fit since class member behaves like a flag.
Add option to scope search to return class member variables.
In linter and hover use option to obtain all variables. In completions use regular option.

jakebailey · 2019-08-12T17:34:01Z

Using my examples in #1231, I can see that the analysis and completion reflect this change, but hovering doesn't:

src/Analysis/Ast/Impl/Types/PythonClassType.cs

jakebailey · 2019-08-12T21:09:35Z

Not sure why, but ReferencesTests.FindAllReferences_MultipleOpenFiles and ReferencesTests.UnrelatedFiles both fail after that change.

) * Initial * Update test * Tell between class members with/without self better * Move interface * Fix reference search

Mikhail Arkhipov added 3 commits August 9, 2019 22:32

Initial

570a925

Update test

318b3cd

Merge master

06112c6

Tell between class members with/without self better

58ae484

jakebailey reviewed Aug 12, 2019

View reviewed changes

src/Analysis/Ast/Impl/Types/PythonClassType.cs Outdated Show resolved Hide resolved

Mikhail Arkhipov added 2 commits August 12, 2019 18:35

Move interface

c924622

Fix reference search

a473a98

MikhailArkhipov mentioned this pull request Aug 13, 2019

Add persistence tests for 60+ system modules #1429

Merged

jakebailey approved these changes Aug 13, 2019

View reviewed changes

MikhailArkhipov merged commit 25b4846 into microsoft:master Aug 13, 2019

jakebailey mentioned this pull request Aug 13, 2019

Class variables are not squiggled when used without class/self prefix #1431

Open

MikhailArkhipov deleted the 1231a branch August 15, 2019 17:59

Provide feedback