This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Handle operators containing equals in fstring parsing #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailArkhipov
approved these changes
Jan 10, 2020
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Handle operators containing equals in fstring parsing * Remove some dead code * Remove LINQ, simplify to property * Just append NextChar in the bufferer function, don't pipe down (cherry picked from commit e31f770)
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Handle operators containing equals in fstring parsing * Remove some dead code * Remove LINQ, simplify to property * Just append NextChar in the bufferer function, don't pipe down (cherry picked from commit e31f770)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1862.
Incorrect lines with things like
/=get double-errors, as the subparser first reaches the end of the input, reports EOF, then the fstring parsing code surrounding it tries to recover from the rest and fails again. Not ideal, but if you're sticking assignment operators into fstrings, two errors isn't the end of the world.