Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

D-X-Y
Copy link
Contributor

@D-X-Y D-X-Y commented Mar 11, 2021

Description

  • The original save_path function is a little bit confused, thus refine it as a get_or_create_path function.
  • For SFM/TabNet, the model is evaluated by the last checkpoint not the best one according to validation.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g you-n-g self-requested a review March 11, 2021 13:12
@you-n-g
Copy link
Collaborator

you-n-g commented Mar 11, 2021

Thanks to @D-X-Y. LGTM

@you-n-g you-n-g merged commit f6b019d into microsoft:main Mar 11, 2021
@D-X-Y
Copy link
Contributor Author

D-X-Y commented Mar 11, 2021

Thanks!

you-n-g added a commit to you-n-g/qlib that referenced this pull request Aug 16, 2025
…rn the ratio (microsoft#328)

* remove AttributeError caused by select_threshold

* develop with ground truth

* raise exception for eval_case

* Revert "develop with ground truth"

This reverts commit e68c136588685476f32a3c3696a6a33deb47acc5.

* Modify FactorRowCountEvaluator and FactorIndexEvaluator to return the ratio

* reformatted by black

* Set the threshold for FactorIndexEvaluator to 0.99

* Apply suggestions from code review

* Update rdagent/components/coder/factor_coder/CoSTEER/evaluators.py

* geometric mean for format_succ_rate

* no need to check when similarity is high enough

* black reformat

---------

Co-authored-by: you-n-g <[email protected]>
gaogen123 pushed a commit to gaogen123/qlib that referenced this pull request Sep 13, 2025
Move get_path to get_or_create_path, use the best model of SFM / TabNet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants