Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[api-extractor] Update API Extractor to support TypeScript 5.3.3 #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 19, 2023
Merged

[api-extractor] Update API Extractor to support TypeScript 5.3.3 #4408

merged 9 commits into from
Dec 19, 2023

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Oct 24, 2023 •
edited
Loading

Summary

Fixes #4404

Details

👉 This is a draft PR because TypeScript 5.3 has not shipped yet. We generally would not do an official API Extractor release that bundles a beta version of the TypeScript compiler.

How it was tested

Confirmed that the API Extractor tests pass.

@octogonz octogonz mentioned this pull request Oct 24, 2023
Closed
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 8, 2023
Merged
3 tasks
jakebailey
jakebailey reviewed Nov 24, 2023
View reviewed changes
@rvion
Copy link

rvion commented Nov 26, 2023 •
edited
Loading

any way to help supporting more recent version of typescript for API Extractor ? not having as const nor proper branch refinments is really forcing more and more antipatterns in code to keep using api-extractor

@octogonz
Copy link
Collaborator Author

octogonz commented Dec 8, 2023

any way to help supporting more recent version of typescript for API Extractor ? not having as const nor proper branch refinments is really forcing more and more antipatterns in code to keep using api-extractor

Thanks for bumping this, @rvion!

Looks like Typescript 5.3.3 has already been released, so we can now proceed with merging this PR. I've converted it to non-draft.

@octogonz octogonz marked this pull request as ready for review December 8, 2023 17:44
D4N14L
D4N14L approved these changes Dec 8, 2023
View reviewed changes
@octogonz
Bump to 5.3.3
3318640
@octogonz
Merge remote-tracking branch 'remotes/origin/main' into octogonz/ae-t…
9eb95ed 
…s-5.3.0-beta

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	common/config/rush/repo-state.json
@octogonz
rush update
d9868cc
@octogonz octogonz changed the title Update API Extractor to support TypeScript 5.3.0-beta Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
@octogonz octogonz merged commit 4cae36c into main Dec 19, 2023
@octogonz octogonz deleted the octogonz/ae-ts-5.3.0-beta branch December 19, 2023 23:32
@octogonz octogonz changed the title Update API Extractor to support TypeScript 5.3.3 [api-extractor ] Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
@octogonz octogonz changed the title [api-extractor ] Update API Extractor to support TypeScript 5.3.3 [api-extractor] Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D4N14L D4N14L D4N14L approved these changes

@iclanton iclanton Awaiting requested review from iclanton iclanton is a code owner

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@dmichon-msft dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

@patmill patmill Awaiting requested review from patmill patmill is a code owner

+1 more reviewer

@jakebailey jakebailey jakebailey left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
Bug Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[api-extractor] ts.getResolvedModule with TypeScript 5.3
4 participants
@octogonz @rvion @D4N14L @jakebailey