Grammar Update for Improved Clarity #1437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a grammatical error in a SQL Server 2019 notebook that demonstrates query performance with trillion-row datasets. The change improves the readability of the performance metrics documentation.
- Fixed grammar in the rows processed per second description by removing an extra article "a"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Read Throughput for physical disk I/O: <font color =\"red\">**~24Gb/sec**</font>\r\n", | ||
| "\r\n", | ||
| "Rows processed per second: <font color=\"red\">**448,717,9024 rows/sec** (*Over a 400 million rows per second*)</font>\r\n", | ||
| "Rows processed per second: <font color=\"red\">**448,717,9024 rows/sec** (*Over 400 million rows per second*)</font>\r\n", |
There was a problem hiding this comment.
The number format '448,717,9024' appears to have an incorrect comma placement. It should likely be '448,717,902' (approximately 448 million) or '4,487,179,024' (approximately 4.4 billion) to align with the description 'Over 400 million rows per second'.
Suggested change
| "Rows processed per second: <font color=\"red\">**448,717,9024 rows/sec** (*Over 400 million rows per second*)</font>\r\n", | |
| "Rows processed per second: <font color=\"red\">**448,717,902 rows/sec** (*Over 400 million rows per second*)</font>\r\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.