Codestin Search App

Copilot · 2026-09-10T18:02:44Z

C# convenience methods deserialize primitive responses with BinaryData.ToObjectFromJson<T>(), which relies on reflection and is not Native AOT-compatible.

Deserialization: Replace reflection-based conversion with typed JsonElement reads for primitive and enum responses, including sync and async methods.
Compatibility: Preserve nullable values, UTF-8 BOM support, and TimeSpan formatting. Leave plain-text, raw binary, model, and collection handling unchanged.

Generated int32 response conversion:

using Stream stream = result.GetRawResponse().Content.ToStream();
using JsonDocument document = JsonDocument.Parse(stream);
return ClientResult.FromValue(document.RootElement.GetInt32(), result.GetRawResponse());

Fixes Generate AOT compatible code when an operation returns a primitive #11930

azure-pipelines · 2026-09-10T18:03:09Z

Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

…ection Co-authored-by: jorgerangel-msft <[email protected]>

Co-authored-by: jorgerangel-msft <[email protected]>

pkg-pr-new · 2026-09-10T19:06:25Z

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@11931

commit: 2c5ad78

Copilot

🟢 Approval recommended

The implementation covers the intended response types and includes focused generation and runtime tests.

Pull request overview

Updates the C# client generator to deserialize primitive and enum responses without reflection, enabling Native AOT compatibility while preserving BOM and nullable handling.

Changes:

Uses typed JsonElement reads for primitive and enum responses.
Preserves plain-text behavior and constant-format TimeSpan conversion.
Adds generation baselines and runtime BOM coverage for sync/async enum responses.

File summaries

File	Description
`TestProjects/Local/Sample-TypeSpec/src/Generated/SampleTypeSpecClient.cs`	Updates generated enum deserialization.
`TestProjects/Local.Tests/ExtensibleEnumTests.cs`	Tests sync/async BOM handling.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(TimeSpanNullable).cs`	Adds nullable `TimeSpan` baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(TimeSpan).cs`	Updates `TimeSpan` baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(String).cs`	Updates string baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Single).cs`	Updates float baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Int64).cs`	Updates `long` baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Int32NullableAsync).cs`	Adds async nullable integer baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Int32Nullable).cs`	Adds nullable integer baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Int32Async).cs`	Adds async integer baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Int32).cs`	Updates integer baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Double).cs`	Updates double baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Decimal).cs`	Adds decimal baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(DateTimeOffset).cs`	Updates date-time baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(BooleanNullable).cs`	Adds nullable boolean baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/ScalarReturnTypeMethods(Boolean).cs`	Updates boolean baseline.
`test/Providers/TestData/ScmMethodProviderCollectionTests/PlainTextReturnTypeMethods.cs`	Verifies plain-text handling.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(True,True,True).cs`	Covers nullable extensible string enum.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(True,True,False).cs`	Covers extensible string enum.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(True,False,False).cs`	Covers fixed string enum.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(False,True,False).cs`	Covers extensible integer enum.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(False,False,True).cs`	Covers nullable fixed integer enum.
`test/Providers/TestData/ScmMethodProviderCollectionTests/EnumReturnTypeMethods(False,False,False).cs`	Covers fixed integer enum.
`test/Providers/ScmMethodProviderCollectionTests.cs`	Expands scalar and enum generation tests.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewRequiredParameterDoesNotAddBackCompatOverload.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewOptionalParameterWithReservedName.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewOptionalNonBodyParameterAddedWithPathAndHeaderParameters.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewOptionalNonBodyParameterAddedWithModelBody.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewOptionalNonBodyParameterAdded.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NewOptionalBodyParameterDoesNotAddBackCompatOverload.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_MultipleNewOptionalNonBodyParametersAdded.cs`	Refreshes generated baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_ConvenienceMethodParamOrderChanged(Sync).cs`	Adds sync body baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_ConvenienceMethodParamOrderChanged(Async).cs`	Adds async body baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_BothMethodsParamOrderChanged(Sync).cs`	Adds sync compatibility baseline.
`test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_BothMethodsParamOrderChanged(Async).cs`	Adds async compatibility baseline.
`test/Providers/ClientProviders/ClientProviderTests.cs`	Moves body assertions to baseline files.
`src/Providers/ScmMethodProviderCollection.cs`	Implements typed response deserialization.

Review details

Files reviewed: 36/37 changed files
Comments generated: 0
Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: jorgerangel-msft <[email protected]>

Jorge Rangel (jorgerangel-msft)

Copilot there's spelling errors we should address by simply changing the test to avoid the warning / error :

 cspell --no-progress .
packages/http-client-csharp/generator/TestProjects/Local.Tests/ExtensibleEnumTests.cs:25:62 - Unknown word (FEFF)

Copilot

🟢 Approval recommended

The implementation is scoped, preserves documented compatibility behavior, and has representative generation and runtime coverage.

Review details

Files reviewed: 38/39 changed files
Comments generated: 0 new
Review effort level: Balanced

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot · 2026-09-10T19:32:04Z

Copilot there's spelling errors we should address by simply changing the test to avoid the warning / error :

Fixed in 5c0d5d6 by adding a // cspell:ignore FEFF comment at the top of the file. Verified npx cspell --no-progress now reports 0 issues for this file.

Copilot

🟡 Changes recommended

Plain-text routing breaks special response types and rejects relative URI values.

Get a fresh assessment by requesting another Copilot review.

Review details

Files reviewed: 59/60 changed files
Comments generated: 2
Review effort level: Balanced

…ive and enum types Co-authored-by: jorgerangel-msft <[email protected]>

Copilot

🔵 Needs a closer look

Plain-text URI responses still reject relative URI values.

Review details

Suppressed comments (1)

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs:943

new Uri(content) rejects relative URL values, while the established JSON and XML deserializers preserve them with UriKind.RelativeOrAbsolute (MrwSerializationTypeDefinition.cs:2454-2455, MrwSerializationTypeDefinition.Xml.cs:1068). Pass that UriKind here and update the plain-text URI baseline to cover a relative value; this also remains unresolved from the prior review thread.

                Type t when t == typeof(Uri) => New.Instance(typeof(Uri), content),

Files reviewed: 63/64 changed files
Comments generated: 0 new
Review effort level: Balanced

…arsing Co-authored-by: jorgerangel-msft <[email protected]>

Copilot

🟡 Changes recommended

Mixed JSON/plain-text string responses can fail when the server returns an unquoted plain-text body.

Get a fresh assessment by requesting another Copilot review.

Review details

Files reviewed: 63/64 changed files
Comments generated: 1
Review effort level: Balanced

…rsions Co-authored-by: jorgerangel-msft <[email protected]>

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot

🟢 Approval recommended

The implementation removes reflection-based conversion while preserving nullable, BOM, plain-text, and special-case behavior with broad baseline coverage.

Review details

Files reviewed: 63/64 changed files
Comments generated: 0 new
Review effort level: Balanced

Jorge Rangel (jorgerangel-msft) · 2026-09-11T23:04:30Z


+            if (IsConvertibleFromBinaryData(responseBodyType)
+                && (responseBodyType.IsFrameworkType || responseBodyType.IsEnum)
+                && !responseBodyType.Equals(typeof(BinaryData))


Copilot why do we need the responseBodyType.Equals(typeof(BinaryData)) check if we are already checked IsConvertibleFromBinaryData ?

IsConvertibleFromBinaryData is a broad capability check (it intentionally returns true for BinaryData), but this specific branch builds JSON-document conversion scaffolding. Without !responseBodyType.Equals(typeof(BinaryData)), BinaryData responses would go through the JSON parse setup instead of preserving the raw payload path. So the extra check keeps BinaryData on its existing direct-content conversion path.

Copilot

🟡 Changes recommended

Nullable plain-text null responses regress when the body contains surrounding whitespace.

Get a fresh assessment by requesting another Copilot review.

Review details

Files reviewed: 63/64 changed files
Comments generated: 1
Review effort level: Balanced

+            return responseBodyType.IsNullable
+                ? new TernaryConditionalExpression(content.Equal(Literal("null")), Null.CastTo(responseBodyType), deserializedValue)
+                : deserializedValue;


Co-authored-by: jorgerangel-msft <[email protected]>

Copilot

🟢 Approval recommended

The reflection-free conversions are localized, preserve documented compatibility cases, and have comprehensive generation and runtime coverage.

Review details

Files reviewed: 63/64 changed files
Comments generated: 0 new
Review effort level: Balanced

JoshLove-msft

Found one new correctness issue in plain-text duration conversion; details inline. Existing review threads were not duplicated.

--generated by Copilot

JoshLove-msft · 2026-09-11T23:26:50Z

+                Type t when t == typeof(bool) => Static<bool>().Invoke(nameof(bool.Parse), content).As<bool>(),
+                Type t when t == typeof(Guid) => Static<Guid>().Invoke(nameof(Guid.Parse), content).As<Guid>(),
+                Type t when t == typeof(Uri) => New.Instance<Uri>(content, FrameworkEnumValue(UriKind.RelativeOrAbsolute)),
+                Type t when t == typeof(TimeSpan) => content.As<string>().ParseTimeSpan(Literal(SerializationFormat.Duration_Constant.ToFormatSpecifier() ?? throw new InvalidOperationException())),


[P2] Honor the duration's wire encoding in the plain-text parser. InputDurationType also maps to TimeSpan, so forcing "c" here makes a seconds-encoded response body 60 deserialize as 60 days instead of one minute, and makes the default ISO 8601 body PT1H throw (the duration encoding mappings are in generator/Microsoft.TypeSpec.Generator/src/TypeFactory.cs:449-474). Select parsing from the response encoding, retaining constant-format parsing for the existing plain-time/constant case, and add ISO 8601 and seconds/milliseconds response coverage.

--generated by Copilot

Initial plan

6fa6ca4

Copilot AI assigned Copilot and Jorge Rangel (jorgerangel-msft) Sep 10, 2026

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 18:03 View session

Copilot AI linked an issue Sep 10, 2026 that may be closed by this pull request

Generate AOT compatible code when an operation returns a primitive #11930

Open

Jorge Rangel (jorgerangel-msft) changed the title ~~[WIP] Generate AOT compatible code for GetSandboxesCount operation~~ [WIP] Generate AOT compatible code for operations that return a primitive as resp body Sep 10, 2026

fix(http-client-csharp): deserialize primitive responses without refl…

79a59cb

…ection Co-authored-by: jorgerangel-msft <[email protected]>

microsoft-github-policy-service Bot added emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp labels Sep 10, 2026

fix(http-client-csharp): preserve BOM handling for primitive responses

bea225a

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI changed the title ~~[WIP] Generate AOT compatible code for operations that return a primitive as resp body~~ Generate AOT-compatible C# primitive responses Sep 10, 2026

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 18:38

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) September 10, 2026 18:38

Jorge Rangel (jorgerangel-msft) reviewed Sep 10, 2026

View reviewed changes

Comment thread ...viders/TestData/ClientProviderTests/BackCompatibility_BothMethodsParamOrderChanged(Async).cs Outdated

Comment thread .../TestData/ClientProviderTests/BackCompatibility_MultipleNewOptionalNonBodyParametersAdded.cs

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot September 10, 2026 19:12

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 19:12 View session

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 19:13 View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

test(http-client-csharp): validate complete primitive response methods

e5e08e6

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 19:21

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) September 10, 2026 19:21

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot September 10, 2026 19:24

Jorge Rangel (jorgerangel-msft) reviewed Sep 10, 2026

View reviewed changes

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 19:25 View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 10, 2026 19:30 View session

Fix cspell error for FEFF in ExtensibleEnumTests.cs

06ea139

Co-authored-by: jorgerangel-msft <[email protected]>

Jorge Rangel (jorgerangel-msft) requested review from JoshLove-msft, Jose Arriaga Maldonado (joseharriaga) and Jesse Squire (jsquire) as code owners September 11, 2026 22:18

Copilot AI review requested due to automatic review settings September 11, 2026 22:18

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:19 View session

Copilot AI reviewed Sep 11, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Outdated

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Outdated

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:25 View session

fix(http-client-csharp): restrict raw text response parsing to primit…

59cd778

…ive and enum types Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI review requested due to automatic review settings September 11, 2026 22:39

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:40 View session

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:41

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:41 View session

Copilot AI reviewed Sep 11, 2026

View reviewed changes

fix(http-client-csharp): allow relative URIs in plain text response p…

46fc557

…arsing Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI review requested due to automatic review settings September 11, 2026 22:44

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:45 View session

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:45

Jorge Rangel (jorgerangel-msft) reviewed Sep 11, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Outdated

Copilot AI reviewed Sep 11, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) September 11, 2026 22:50 View session

fix(http-client-csharp): return null for unsupported plain text conve…

30b9413

…rsions Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI review requested due to automatic review settings September 11, 2026 22:57

refactor(http-client-csharp): resolve plain text parser before content

de7abee

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI reviewed Sep 11, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) reviewed Sep 11, 2026

View reviewed changes

Copilot AI reviewed Sep 11, 2026

View reviewed changes

Copilot AI and others added 2 commits September 11, 2026 23:11

test(http-client-csharp): avoid FEFF token in Local extensible enum test

cd41087

Co-authored-by: jorgerangel-msft <[email protected]>

test(http-client-csharp): build BOM prefix from UTF-8 preamble

2c5ad78

Co-authored-by: jorgerangel-msft <[email protected]>

Copilot AI reviewed Sep 11, 2026

View reviewed changes

JoshLove-msft reviewed Sep 11, 2026

View reviewed changes

Uh oh!

Conversation

Copilot AI commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Sep 10, 2026

Uh oh!

pkg-pr-new Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Jorge Rangel (jorgerangel-msft) left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI commented Sep 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Suppressed comments (1)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Jorge Rangel (jorgerangel-msft) Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

JoshLove-msft left a comment

Choose a reason for hiding this comment

Uh oh!

JoshLove-msft Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 10, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 10, 2026 •

edited

Loading