Update Python release skill guidance - #11937
Conversation
There was a problem hiding this comment.
π‘ Changes recommended
The fallback must handle partial updates, and the proposed-version prompt needs clarification.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Python release skill guidance for version handling and post-release review.
Changes:
- Adds fallback version/changelog updates.
- Requires version consistency checks.
- Adds evidence-based post-process review guidance.
File summaries
| File | Summary |
|---|---|
.github/skills/http-client-python-bump-and-release/SKILL.md |
Updates release workflow and review guidance. |
Review details
Suppressed comments (2)
.github/skills/http-client-python-bump-and-release/SKILL.md:84
- This check is nested inside the fallback instructions, so the normal path where Chronus updates both files does not clearly perform the new consistency requirement. Move the check outside the fallback block and explicitly stop or correct the release before building if the values differ.
- Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.
.github/skills/http-client-python-bump-and-release/SKILL.md:112
- The workflow ends by creating a PR and does not publish a package, so there is no released package version to report at this point. Rename this to the proposed
@typespec/http-client-pythonversion (or define a separate published artifact/version), rather than asking for an ambiguous value alongside the same package's version.
6. Return the branch name, released package version, `@typespec/http-client-python` version, commit hash, pull request URL, review findings, and any skill update to the user.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
π‘ Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No changes needing a change description found. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
Copilot fix format issue for my changed files |
There was a problem hiding this comment.
π΅ Needs a closer look
Fallback handling and consistency validation need correction.
Review details
Suppressed comments (2)
.github/skills/http-client-python-bump-and-release/SKILL.md:73
- This condition applies both fallback actions whenever either artifact is missing. If Chronus updated
package.jsonbut notCHANGELOG.md(or vice versa), the next steps can increment an already-bumped version or add a duplicate release heading; restrict the full fallback to the case where neither file changed and repair only the missing artifact for a partial update.
Verify that the script updated both the emitter version in `package.json` and `CHANGELOG.md`. If either file was not updated:
.github/skills/http-client-python-bump-and-release/SKILL.md:84
- This consistency check is nested under the manual-fallback bullets, so the normal path where the version script updates both files does not explicitly verify that
package.jsonmatches the changelog heading. Make the check an unconditional postcondition after either the script or fallback completes, otherwise a mismatched release can still be committed.
- Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: msyyc <[email protected]>
There was a problem hiding this comment.
π‘ Changes recommended
The fallback logic can duplicate version increments and changelog entries after a partial update.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
.github/skills/http-client-python-bump-and-release/SKILL.md:85
- This verification is nested inside the fallback list, so it is skipped when the version script updates both files normally. The stated requirement is to keep these values consistent on every run; make this an unconditional step-level check so a script-generated mismatch is also caught.
- Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
There was a problem hiding this comment.
π΅ Needs a closer look
Partial version/changelog updates can leave the release workflow inconsistent.
Review details
Suppressed comments (1)
.github/skills/http-client-python-bump-and-release/SKILL.md:73
- This only handles the all-or-nothing failure case. If the script changes exactly one of these files, the workflow continues with an inconsistent version/changelog pair and the fallback is skipped; add an explicit partial-update failure/repair path before proceeding.
Verify that the script updated both the emitter version in `package.json` and `CHANGELOG.md`. If neither file was updated:
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
You can try these changes here
|
Summary
Validation
git diff --checkpasses