Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Python release skill guidance - #11937

Open
Yuchao Yan (msyyc) wants to merge 4 commits into
mainfrom
update-python-release-skill
Open

Update Python release skill guidance#11937
Yuchao Yan (msyyc) wants to merge 4 commits into
mainfrom
update-python-release-skill

Conversation

@msyyc

Copy link
Copy Markdown
Contributor

Summary

  • add a fallback when the Python emitter version script updates neither the package version nor changelog
  • require the package version and changelog heading to remain consistent
  • add an evidence-based post-process review for completed release runs

Validation

  • Markdown diagnostics report no errors
  • git diff --check passes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟑 Changes recommended

The fallback must handle partial updates, and the proposed-version prompt needs clarification.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Python release skill guidance for version handling and post-release review.

Changes:

  • Adds fallback version/changelog updates.
  • Requires version consistency checks.
  • Adds evidence-based post-process review guidance.
File summaries
File Summary
.github/skills/http-client-python-bump-and-release/SKILL.md Updates release workflow and review guidance.
Review details

Suppressed comments (2)

.github/skills/http-client-python-bump-and-release/SKILL.md:84

  • This check is nested inside the fallback instructions, so the normal path where Chronus updates both files does not clearly perform the new consistency requirement. Move the check outside the fallback block and explicitly stop or correct the release before building if the values differ.
    - Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.

.github/skills/http-client-python-bump-and-release/SKILL.md:112

  • The workflow ends by creating a PR and does not publish a package, so there is no released package version to report at this point. Rename this to the proposed @typespec/http-client-python version (or define a separate published artifact/version), rather than asking for an ambiguous value alongside the same package's version.
6. Return the branch name, released package version, `@typespec/http-client-python` version, commit hash, pull request URL, review findings, and any skill update to the user.
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

πŸ’‘ Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/skills/http-client-python-bump-and-release/SKILL.md
@github-actions

Copy link
Copy Markdown
Contributor

No changes needing a change description found.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot AI review requested due to automatic review settings September 11, 2026 03:56
@msyyc

Copy link
Copy Markdown
Contributor Author

Copilot fix format issue for my changed files

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΅ Needs a closer look

Fallback handling and consistency validation need correction.

Review details

Suppressed comments (2)

.github/skills/http-client-python-bump-and-release/SKILL.md:73

  • This condition applies both fallback actions whenever either artifact is missing. If Chronus updated package.json but not CHANGELOG.md (or vice versa), the next steps can increment an already-bumped version or add a duplicate release heading; restrict the full fallback to the case where neither file changed and repair only the missing artifact for a partial update.
   Verify that the script updated both the emitter version in `package.json` and `CHANGELOG.md`. If either file was not updated:

.github/skills/http-client-python-bump-and-release/SKILL.md:84

  • This consistency check is nested under the manual-fallback bullets, so the normal path where the version script updates both files does not explicitly verify that package.json matches the changelog heading. Make the check an unconditional postcondition after either the script or fallback completes, otherwise a mismatched release can still be committed.
    - Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 11, 2026 04:01

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Copilot fix format issue for my changed files

Fixed and formatted in 6256457.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟑 Changes recommended

The fallback logic can duplicate version increments and changelog entries after a partial update.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

.github/skills/http-client-python-bump-and-release/SKILL.md:85

  • This verification is nested inside the fallback list, so it is skipped when the version script updates both files normally. The stated requirement is to keep these values consistent on every run; make this an unconditional step-level check so a script-generated mismatch is also caught.
   - Verify that the version in `package.json` matches the new `CHANGELOG.md` heading.
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/skills/http-client-python-bump-and-release/SKILL.md Outdated
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot AI review requested due to automatic review settings September 11, 2026 04:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΅ Needs a closer look

Partial version/changelog updates can leave the release workflow inconsistent.

Review details

Suppressed comments (1)

.github/skills/http-client-python-bump-and-release/SKILL.md:73

  • This only handles the all-or-nothing failure case. If the script changes exactly one of these files, the workflow continues with an inconsistent version/changelog pair and the fallback is skipped; add an explicit partial-update failure/repair path before proceeding.
   Verify that the script updated both the emitter version in `package.json` and `CHANGELOG.md`. If neither file was updated:
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@azure-sdk-automation

azure-sdk-automation Bot commented Sep 11, 2026

Copy link
Copy Markdown

You can try these changes here

πŸ› Playground 🌐 Website πŸ› VSCode Extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants