[cppcoro] add new port #10693

luncliff · 2020-04-04T12:42:47Z

Previously there was #7779 to add https://github.com/lewissbaker/cppcoro, but it is closed for some reason.

Since the fork defines minimum CMake configurations, I expect the port will be available in the most Desktop(or so-called non-mobile) triplets.

Related Issues

Help add repo cppcoro #5106 (port request)

NancyLi1013 · 2020-04-07T03:24:46Z

/azp run

ports/cppcoro/CONTROL

ports/cppcoro/portfile.cmake

NancyLi1013 · 2020-04-07T05:45:26Z

Hi @luncliff
Thanks for this PR.
Could you please look into the regression on Linux and try to fix it?

luncliff · 2020-04-07T13:34:17Z

Thanks for very fast review, @NancyLi1013.
I will apply the requested changes and push again within days.

For #10693 (comment),
If you think registration of the forked repo is inappropriate, please feel free to close this :)

luncliff · 2020-04-07T13:43:15Z

For Linux build failure, the errors are something like this.

[1/20] /usr/bin/c++   -I/mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/include -fPIC -g   -std=gnu++17 -MD -MT CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o -MF CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o.d -o CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o -c /mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/lib/async_mutex.cpp
FAILED: CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o 
/usr/bin/c++   -I/mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/include -fPIC -g   -std=gnu++17 -MD -MT CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o -MF CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o.d -o CMakeFiles/cppcoro.dir/lib/async_mutex.cpp.o -c /mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/lib/async_mutex.cpp
In file included from /mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/lib/async_mutex.cpp:6:
/mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b/include/cppcoro/async_mutex.hpp:8:10: fatal error: experimental/coroutine: No such file or directory
    8 | #include <experimental/coroutine>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
...

As far as I know, there are 2 problems.

GCC 7 doesn't support C++ Coroutines (TS) feature. We need at least GCC 10
The build requires libc++, instead of libstdc++

For case 1, the user can workaround with CC=clang, CXX=clang.
For case 2, (optional) triplet (x64-linux) customization is required to enforce specific version of libc++.

luncliff@CIC:/mnt/develop/vcpkg$ export CC=clang++-8 CXX=clang++-8
luncliff@CIC:/mnt/develop/vcpkg$ ./vcpkg install cppcoro
Computing installation plan...
The following packages will be built and installed:
    cppcoro[core]:x64-linux
Starting package 1/1: cppcoro:x64-linux
Building package cppcoro[core]:x64-linux...
-- Using cached /mnt/develop/vcpkg/downloads/luncliff-cppcoro-20b4217a65165d0ec7849fbe7970310cdf31b6a5.tar.gz                                                                                                              tar.gz
-- Using source at /mnt/develop/vcpkg/buildtrees/cppcoro/src/0cdf31b6a5-b830c1617b
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /mnt/develop/vcpkg/packages/cppcoro_x64-linux/share/cppcoro/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package cppcoro[core]:x64-linux... done
Installing package cppcoro[core]:x64-linux...
Installing package cppcoro[core]:x64-linux... done
Elapsed time for package cppcoro:x64-linux: 28.41 s

Total elapsed time: 28.42 s

The package cppcoro:x64-linux provides CMake targets:

    find_package(cppcoro CONFIG REQUIRED)
    target_link_libraries(main PRIVATE cppcoro)

* update reference to tag and hash value * ${PORT} for destination Linux build support should marked unavailable?

ports/cppcoro/CONTROL

NancyLi1013 · 2020-04-08T07:13:28Z

@luncliff
Thanks for your deep investigation about the regression on Linux.
As far as I'm concerned, most users installed gcc version less than 10.
For libc++, we prefer to use the triplet that vcpkg supports instead of custom triplet.
So currently I suggest that we had better disable the support for linux.

ports/cppcoro/portfile.cmake

NancyLi1013 · 2020-04-09T01:48:27Z

/azp run

* copy the CMakeLists.txt file and start build with it * change version to 2020.2 For now the repo doesn't have any tags. Therefore its version followed the latest commit, which is made in 2020 Feb.

luncliff · 2020-04-10T09:21:59Z

Thanks for your feedback, @NancyLi1013 . I just embedded CMakeLists.txt, and marked Supports: !(uwp|linux).

luncliff · 2020-04-10T09:23:50Z

Since the original repo doesn't have tag, I used version code 2020.02.
(the latest commit was made in 2020 Feb)

NancyLi1013 · 2020-04-10T10:26:46Z

If there is no released version, you can use a date that you accept the latest commit.
Please refer to this doc.

luncliff · 2020-04-10T10:45:55Z

@NancyLi1013 I will check the other parts again :)

NancyLi1013 · 2020-04-13T06:08:39Z

@luncliff Thanks for your update.
Is there anything else you want to check or update now?

luncliff · 2020-04-13T09:32:06Z

@luncliff Thanks for your update.
Is there anything else you want to check or update now?

Looks good to me with current state. Do I have to rebase the commits?

ports/cppcoro/portfile.cmake

* vcpkg_fail_port_install on uwp/linux mention PR #10693 so linux/clang users can see the port issues

ports/cppcoro/CMakeLists.txt

* report error for clang-cl build with VC++ in VS 2019 will fail by the header file.

ports/cppcoro/portfile.cmake

NancyLi1013 · 2020-04-21T02:19:58Z

/azp run

azure-pipelines · 2020-04-21T02:20:04Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

…2019 builds.

ras0219-msft · 2020-04-24T21:01:45Z

Thanks for the PR!

luncliff · 2020-04-25T02:56:19Z

Appreciate for the reviews! Would you close the #5106?

[cppcoro] add new port

aff31e1

PhoebeHui assigned NancyLi1013 Apr 7, 2020

NancyLi1013 suggested changes Apr 7, 2020

View reviewed changes

ports/cppcoro/CONTROL Outdated Show resolved Hide resolved

ports/cppcoro/portfile.cmake Outdated Show resolved Hide resolved

ports/cppcoro/portfile.cmake Show resolved Hide resolved

NancyLi1013 suggested changes Apr 7, 2020

View reviewed changes

ports/cppcoro/portfile.cmake Outdated Show resolved Hide resolved

ports/cppcoro/portfile.cmake Outdated Show resolved Hide resolved

NancyLi1013 added the waiting for response label Apr 7, 2020

[cppcoro] update with PR review

dfdb209

* update reference to tag and hash value * ${PORT} for destination Linux build support should marked unavailable?

NancyLi1013 suggested changes Apr 8, 2020

View reviewed changes

ports/cppcoro/CONTROL Outdated Show resolved Hide resolved

NancyLi1013 suggested changes Apr 8, 2020

View reviewed changes

ports/cppcoro/portfile.cmake Outdated Show resolved Hide resolved

[cppcoro] embed CMakeLists.txt file

7e6235b

* copy the CMakeLists.txt file and start build with it * change version to 2020.2 For now the repo doesn't have any tags. Therefore its version followed the latest commit, which is made in 2020 Feb.

[cppcoro] 2020-02-28

91b61bc

NancyLi1013 suggested changes Apr 16, 2020

View reviewed changes

ports/cppcoro/portfile.cmake Show resolved Hide resolved

NancyLi1013 assigned JackBoosY Apr 16, 2020

[cppcoro] port install failure on platforms

6c23ad6

* vcpkg_fail_port_install on uwp/linux mention PR #10693 so linux/clang users can see the port issues

NancyLi1013 approved these changes Apr 16, 2020

View reviewed changes

JackBoosY suggested changes Apr 16, 2020

View reviewed changes

ports/cppcoro/CMakeLists.txt Outdated Show resolved Hide resolved

ports/cppcoro/CMakeLists.txt Outdated Show resolved Hide resolved

ports/cppcoro/CMakeLists.txt Outdated Show resolved Hide resolved

[cppcoro] force static linkage

b3c031a

* report error for clang-cl build with VC++ in VS 2019 will fail by the header file.

JackBoosY suggested changes Apr 20, 2020

View reviewed changes

ports/cppcoro/portfile.cmake Outdated Show resolved Hide resolved

[cppcoro] register ci.baseline failure

fe0202d

luncliff requested a review from JackBoosY April 22, 2020 10:49

JackBoosY approved these changes Apr 23, 2020

View reviewed changes

JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 23, 2020

[cppcoro] Simplify CMakeLists.txt to ease future maintenance. Fix VS …

b009c2e

…2019 builds.

ras0219-msft merged commit 84f94fb into microsoft:master Apr 24, 2020

luncliff deleted the cppcoro branch April 26, 2020 06:42

luncliff mentioned this pull request May 28, 2020

Added CMake build system lewissbaker/cppcoro#110

Draft

chausner mentioned this pull request Jul 5, 2020

please provide vcpkg support lewissbaker/cppcoro#112

Open

luncliff mentioned this pull request Jan 29, 2021

Add example for using libc++ on Linux #9783

Closed

tmoonlight mentioned this pull request Jul 6, 2024

[cppcoro] Build error on x64-linux #39732

Closed

dg0yt mentioned this pull request Jul 6, 2024

[cppcoro] Build error on x64-linux #39733

Closed

[cppcoro] add new port #10693

[cppcoro] add new port #10693

Uh oh!

Conversation

luncliff commented Apr 4, 2020

Related Issues

Uh oh!

NancyLi1013 commented Apr 7, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 7, 2020

Uh oh!

luncliff commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luncliff commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 8, 2020

Uh oh!

Uh oh!

NancyLi1013 commented Apr 9, 2020

Uh oh!

luncliff commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luncliff commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Apr 10, 2020

Uh oh!

luncliff commented Apr 10, 2020

Uh oh!

NancyLi1013 commented Apr 13, 2020

Uh oh!

luncliff commented Apr 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented Apr 21, 2020

Uh oh!

azure-pipelines bot commented Apr 21, 2020

Uh oh!

ras0219-msft commented Apr 24, 2020

Uh oh!

luncliff commented Apr 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

luncliff commented Apr 7, 2020 •

edited

Loading

luncliff commented Apr 7, 2020 •

edited

Loading

luncliff commented Apr 10, 2020 •

edited

Loading

luncliff commented Apr 10, 2020 •

edited

Loading

luncliff commented Apr 13, 2020 •

edited

Loading