Add SolutionArgumentException with error types #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
kasperk81
reviewed
Nov 14, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
kasperk81
reviewed
Nov 14, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
kasperk81
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
after this is merged and published need to update source build dotnet/source-build-externals#392 then publish to dotnet9 and 10 feeds, update msbuild and then sdk. (that's one of many reasons i was suggesting to make your life and the sdk implementation simpler and handle this error cases less pedantically)
kasperk81
reviewed
Nov 15, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
kasperk81
reviewed
Nov 15, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
…rgumentException.cs Co-authored-by: kasperk81 <[email protected]>
kasperk81
reviewed
Nov 15, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
kasperk81
reviewed
Nov 16, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionArgumentException.cs
Outdated
Show resolved
Hide resolved
kasperk81
reviewed
Nov 18, 2024
|
|
||
| public class SolutionArgumentException : ArgumentException | ||
| { | ||
| public readonly SolutionErrorType Type; |
There was a problem hiding this comment.
Suggested change
| public readonly SolutionErrorType Type; | |
| public SolutionErrorType Type { get; init; } |
by convention, this should be a readonly property
richardstanton
approved these changes
Nov 18, 2024
kasperk81
reviewed
Nov 18, 2024
src/Microsoft.VisualStudio.SolutionPersistence/Model/SolutionException.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is difficult for users of this library to compare and classify
ArgumentExceptions, especially since the messages are formatted, localized strings.This creates a new class
SolutionArgumentExceptionthat additionally has aTypeproperty that corresponds to a member of enumSolutionArgumentExceptionType.