Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make VSTHRD200 ignore DisposeAsyncCore #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 1 commit into from
Oct 9, 2023
Merged

Make VSTHRD200 ignore DisposeAsyncCore #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Microsoft.VisualStudio.Threading.Analyzers/VSTHRD200UseAsyncNamingConventionAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ private void AnalyzeNode(SymbolAnalysisContext context, CommonInterest.Awaitable
return;
}

// Skip the method of the recommended dispose pattern.
if (methodSymbol.Name == "DisposeAsyncCore")
{
return;
}

bool hasAsyncFocusedReturnType = Utils.HasAsyncCompatibleReturnType(methodSymbol);

bool actuallyEndsWithAsync = methodSymbol.Name.EndsWith(MandatoryAsyncSuffix, StringComparison.CurrentCulture);
Expand Down
23 changes: 23 additions & 0 deletions ....VisualStudio.Threading.Analyzers.Tests/VSTHRD200UseAsyncNamingConventionAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,29 @@ public async Task TaskReturningPropertyWithoutSuffix_GeneratesNoWarning()
class Test {
Task Foo => null;
}
";
await CSVerify.VerifyAnalyzerAsync(test);
}

[Fact]
public async Task MethodDisposeAsyncCore_GeneratesNoWarning()
{
var test = @"
using System;
using System.Threading.Tasks;

class Test : IAsyncDisposable
{
public async ValueTask DisposeAsync()
{
await DisposeAsyncCore().ConfigureAwait(false);
GC.SuppressFinalize(this);
}

protected virtual async ValueTask DisposeAsyncCore()
{
}
}
";
await CSVerify.VerifyAnalyzerAsync(test);
}
Expand Down