fix: memory leak in decorationAddon._decorations - #326933
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits intoJul 31, 2026
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes terminal decoration resource leaks by cleaning up hover and context-menu disposables when their xterm decoration is disposed.
Changes:
- Disposes decoration-scoped resources during decoration teardown.
- Removes disposed decorations from the tracking map.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Jul 31, 2026
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
July 31, 2026 00:17
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Anthony Kim (anthonykim1)
approved these changes
Jul 31, 2026
Don Jayamanne (DonJayamanne)
approved these changes
Jul 31, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/terminal-decoration-marker-memory-leak
branch
August 13, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Disposes terminal decoration hover and context menu resources with their marker.
Before
When running the same task 37 times, terminal decoration callbacks grow each time (outlined in red):
After
No more leak is detected for these callbacks.